From: Ian Lance Taylor <ian@gcc.gnu.org>
Date: Fri, 27 Sep 2013 22:13:11 +0000 (+0000)
Subject: reflect: Copy stack values onto heap in amd64 MakeFunc.
X-Git-Tag: releases/gcc-4.9.0~3835
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f18389f4de6f422a50ccd69d63c067e859fc50d;p=thirdparty%2Fgcc.git

reflect: Copy stack values onto heap in amd64 MakeFunc.

From-SVN: r202995
---

diff --git a/libgo/go/reflect/makefuncgo_amd64.go b/libgo/go/reflect/makefuncgo_amd64.go
index bdc655605061..ecc50a42520a 100644
--- a/libgo/go/reflect/makefuncgo_amd64.go
+++ b/libgo/go/reflect/makefuncgo_amd64.go
@@ -431,8 +431,14 @@ argloop:
 func amd64Memarg(in []Value, ap uintptr, rt *rtype) ([]Value, uintptr) {
 	ap = align(ap, ptrSize)
 	ap = align(ap, uintptr(rt.align))
-	p := Value{rt, unsafe.Pointer(ap), flag(rt.Kind()<<flagKindShift) | flagIndir}
-	in = append(in, p)
+
+	// We have to copy the argument onto the heap in case the
+	// function hangs onto the reflect.Value we pass it.
+	p := unsafe_New(rt)
+	memmove(p, unsafe.Pointer(ap), rt.size)
+
+	v := Value{rt, p, flag(rt.Kind()<<flagKindShift) | flagIndir}
+	in = append(in, v)
 	ap += rt.size
 	return in, ap
 }