From: John Ferlan <jferlan@redhat.com>
Date: Mon, 1 Dec 2014 16:10:18 +0000 (-0500)
Subject: libxl: Resolve Coverity CHECKED_RETURN
X-Git-Tag: CVE-2014-8135~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f1d3c6c875fa926a657789dcb8ba4a57713dc88;p=thirdparty%2Flibvirt.git

libxl: Resolve Coverity CHECKED_RETURN

Commit id 'cb88d433' refactored the calling sequence to use a thread;
however, in doing so "lost" the check for if virNetSocketAccept returns
failure.  Since other code makes that check, Coverity complains. Although
a false positive, adding back the failure check pacifies Coverity
---

diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c
index 0caa3d0734..4db89b63d7 100644
--- a/src/libxl/libxl_migration.c
+++ b/src/libxl/libxl_migration.c
@@ -133,8 +133,7 @@ libxlMigrateReceive(virNetSocketPtr sock,
     size_t i;
 
     /* Accept migration connection */
-    virNetSocketAccept(sock, &client_sock);
-    if (client_sock == NULL) {
+    if (virNetSocketAccept(sock, &client_sock) < 0 || !client_sock) {
         virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                        _("Failed to accept migration connection"));
         goto fail;