From: Francis Dupont <fdupont@isc.org>
Date: Mon, 19 Nov 2018 16:14:02 +0000 (+0100)
Subject: [65-libyang-simplify-update-models] Removed defaults
X-Git-Tag: 75-radius-documentation-needs-an-update_base~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f1eea775b5042cac788821014ab6ad778891ad9;p=thirdparty%2Fkea.git

[65-libyang-simplify-update-models] Removed defaults
---

diff --git a/src/lib/yang/models/kea-ctrl-agent.yang b/src/lib/yang/models/kea-ctrl-agent.yang
index 9d94224925..f886413b5f 100644
--- a/src/lib/yang/models/kea-ctrl-agent.yang
+++ b/src/lib/yang/models/kea-ctrl-agent.yang
@@ -8,9 +8,11 @@ module kea-ctrl-agent {
   }
   import kea-types {
     prefix kea;
+    revision-date 2018-09-14;
   }
   import kea-logging {
     prefix logging;
+    revision-date 2018-11-11;
   }
 
   organization "Internet Systems Consortium";
@@ -18,7 +20,7 @@ module kea-ctrl-agent {
   description "This model defines a YANG data model that can be
                used to configure and manage a Kea control agent.";
 
-  revision 2018-09-14 {
+  revision 2018-11-11 {
     description "Initial revision";
     reference "";
   }
@@ -33,13 +35,11 @@ module kea-ctrl-agent {
 
     leaf http-host {
       type inet:ip-address;
-      default "127.0.0.1";
       description "IP address to which HTTP service will be bound.";
     }
 
     leaf http-port {
       type uint16;
-      default 8000;
       description "Port to which HTTP service will be bound.";
     }
 
diff --git a/src/lib/yang/models/kea-dhcp-ddns.yang b/src/lib/yang/models/kea-dhcp-ddns.yang
index 56f4e54734..f0622326d1 100644
--- a/src/lib/yang/models/kea-dhcp-ddns.yang
+++ b/src/lib/yang/models/kea-dhcp-ddns.yang
@@ -8,9 +8,11 @@ module kea-dhcp-ddns {
   }
   import kea-types {
     prefix kea;
+    revision-date 2018-09-14;
   }
   import kea-logging {
     prefix logging;
+    revision-date 2018-11-11;
   }
 
   organization "Internet Systems Consortium";
@@ -18,7 +20,7 @@ module kea-dhcp-ddns {
   description "This model defines a YANG data model that can be
     used to configure and manage a Kea DHCP-DDNS server.";
 
-  revision 2018-09-14 {
+  revision 2018-11-11 {
     description "Initial revision";
     reference "";
   }
@@ -61,7 +63,6 @@ module kea-dhcp-ddns {
             }
             leaf port {
               type uint16;
-              default 53;
               description "DNS server port.";
             }
             leaf user-context {
@@ -88,13 +89,11 @@ module kea-dhcp-ddns {
 
     leaf ip-address {
       type inet:ip-address;
-      default "127.0.0.1";
       description "IP address on which the server listens for requests.";
     }
 
     leaf port {
       type uint16;
-      default 53001;
       description "Port on which the server listens for requests.";
     }
 
@@ -114,7 +113,6 @@ module kea-dhcp-ddns {
           description "TCP transport";
         }
       }
-      default "UDP";
       description "Protocol to use when sending requests to the server.";
     }
 
@@ -124,7 +122,6 @@ module kea-dhcp-ddns {
           description "JSON format";
         }
       }
-      default "JSON";
       description "Packet format to use when sending requests to the server.";
     }
 
@@ -156,7 +153,6 @@ module kea-dhcp-ddns {
         leaf digest-bits {
            type uint16;
            units "bits";
-           default 0;
            description "Minimum truncated length. 0 means no truncation.";
         }
         leaf secret {
diff --git a/src/lib/yang/models/kea-dhcp-types.yang b/src/lib/yang/models/kea-dhcp-types.yang
index 6f6ec5ef91..e47bd11835 100644
--- a/src/lib/yang/models/kea-dhcp-types.yang
+++ b/src/lib/yang/models/kea-dhcp-types.yang
@@ -8,13 +8,14 @@ module kea-dhcp-types {
   }
   import kea-types {
     prefix kea;
+    revision-date 2018-09-14;
   }
 
   organization "Internet Systems Consortium";
   contact "kea-dev@lists.isc.org";
   description "This file defines some commonly used Kea DHCP types and
                groupings.";
-  revision 2018-09-14 {
+  revision 2018-11-11 {
     description "Initial revision";
     reference "";
   }
@@ -37,7 +38,6 @@ module kea-dhcp-types {
         description "Allows only global host reservations.";
       }
     }
-    default "all";
     description "Host reservation mode.";
   }
 
@@ -53,7 +53,6 @@ module kea-dhcp-types {
         description "Expired-reclaimed";
       }
     }
-    default "default";
     description "Defines state of the lease.";
   }
 
@@ -112,7 +111,6 @@ module kea-dhcp-types {
     }
     leaf persist {
       type boolean;
-      default true;
       description "Write lease to disk file. This parameter applies only to
                    memfile backend.";
     }
@@ -123,12 +121,10 @@ module kea-dhcp-types {
     leaf lfc-interval {
       type uint32;
       units "seconds";
-      default 3600;
       description "Interval between two lease file cleanups.";
     }
     leaf readonly {
       type boolean;
-      default false;
       description "If set to true, the database will be connected in
                    read-only mode. This does not make sense for lease
                    databases, only for host reservations and possibly
@@ -151,13 +147,11 @@ module kea-dhcp-types {
     }
     leaf max-reconnect-tries {
       type uint32;
-      default 0;
       description "Maximum of recovery attempts before exit.";
     }
     leaf reconnect-wait-time {
       type uint32;
       units "milliseconds";
-      default 0;
       description "Waiting delay between two recovery attempts.";
     }
     leaf request-timeout {
@@ -168,12 +162,10 @@ module kea-dhcp-types {
     leaf tcp-keepalive {
       type uint32;
       units "seconds";
-      default 0;
       description "TCP keepalive for the database connection.";
     }
     leaf tcp-nodelay {
       type boolean;
-      default true;
       description "TCP nodelay for the database connection.";
     }
     uses kea:user-context {
@@ -208,35 +200,29 @@ module kea-dhcp-types {
       leaf reclaim-timer-wait-time {
         type uint32;
         units "seconds";
-        default 10;
         description "Interval between reclamation cycles.";
       }
       leaf flush-reclaimed-timer-wait-time {
         type uint32;
         units "seconds";
-        default 25;
         description "Interval between reclaimed leases collection.";
       }
       leaf hold-reclaimed-time {
         type uint32;
         units "seconds";
-        default 3600;
         description "Hold timer for re-assignment.";
       }
       leaf max-reclaim-leases {
         type uint32;
-        default 100;
         description "Maximum number of reclaimed leases per cycle.";
       }
       leaf max-reclaim-time {
         type uint32;
         units "milliseconds";
-        default 250;
         description "Maximum duration of a reclamation cycle.";
       }
       leaf unwarned-reclaim-cycles {
         type uint32;
-        default 5;
         description "Maximum numbers of uncomplete cycles before warning.";
       }
     }
@@ -257,7 +243,6 @@ module kea-dhcp-types {
       description "DHCP-DDNS client setup.";
       leaf enable-updates {
         type boolean;
-        default false;
         description "Enable DHCP-DDNS updates.";
       }
       leaf qualifying-suffix {
@@ -266,12 +251,10 @@ module kea-dhcp-types {
       }
       leaf server-ip {
         type inet:ip-address;
-        default "127.0.0.1";
         description "DHCP-DDNS server IP address.";
       }
       leaf server-port {
         type uint16;
-        default 53001;
         description "DHCP-DDNS server port.";
       }
       leaf sender-ip {
@@ -284,7 +267,6 @@ module kea-dhcp-types {
       }
       leaf max-queue-size {
         type uint32;
-        default 1024;
         description "Maximum DHCP-DDNS queue size.";
       }
       leaf ncr-protocol {
@@ -296,7 +278,6 @@ module kea-dhcp-types {
             description "TCP transport";
           }
         }
-        default "UDP";
         description "Protocol to use for DHCP-DDNS communication.
                      Currently only UDP is supported.";
       }
@@ -306,17 +287,14 @@ module kea-dhcp-types {
             description "JSON format";
           }
         }
-        default "JSON";
         description "Packet format to use for DHCP-DDNS.";
       }
       leaf override-no-update {
         type boolean;
-        default false;
         description "Ignore client request and send update.";
       }
       leaf override-client-update {
         type boolean;
-        default false;
         description "Ignore client delegation.";
       }
       leaf replace-client-name {
@@ -334,12 +312,10 @@ module kea-dhcp-types {
             description "When the client did not send a name.";
           }
         }
-        default "never";
         description "Replace the name provided by the client.";
       }
       leaf generated-prefix {
         type string;
-        default "myhost";
         description "DHCP-DDNS generated prefix.";
       }
       leaf hostname-char-set {
@@ -386,7 +362,6 @@ module kea-dhcp-types {
             description "When a check fails reject the lease.";
           }
         }
-        default "warn";
         description "Lease checks: verify subnet-id consistency on memfile
                      loading.";
       }
@@ -572,7 +547,6 @@ module kea-dhcp-types {
     description "Interfaces re-detect grouping.";
     leaf re-detect {
       type boolean;
-      default false;
       description "Re-detect interfaces at each reconfiguration.";
     }
   }
@@ -599,7 +573,6 @@ module kea-dhcp-types {
     description "Client class only-if-required grouping.";
     leaf only-if-required {
       type boolean;
-      default false;
       description "Client class only if required flag.";
     }
   }
@@ -660,7 +633,6 @@ module kea-dhcp-types {
     description "Option data csv-format grouping.";
     leaf csv-format {
       type boolean;
-      default true;
       description "If true, the option is specified as comma separated
                    values.  If false, it is expected as a hex string.";
     }
@@ -670,7 +642,6 @@ module kea-dhcp-types {
     description "Option data always-send grouping.";
     leaf always-send {
       type boolean;
-      default false;
       description "Defines whether to always send the option,
                    regardless if the client requested it or not.";
     }
@@ -680,7 +651,6 @@ module kea-dhcp-types {
     description "Option data array grouping.";
     leaf array {
       type boolean;
-      default false;
       description "Option definition array flag.";
     }
   }
@@ -690,7 +660,6 @@ module kea-dhcp-types {
     leaf decline-probation-period {
       type uint32;
       units "seconds";
-      default 86400;
       description "Decline probabation period.";
     }
   }
diff --git a/src/lib/yang/models/kea-dhcp4-server.yang b/src/lib/yang/models/kea-dhcp4-server.yang
index 3ae0a6f743..6a164d09d6 100644
--- a/src/lib/yang/models/kea-dhcp4-server.yang
+++ b/src/lib/yang/models/kea-dhcp4-server.yang
@@ -12,11 +12,11 @@ module kea-dhcp4-server {
   }
   import kea-dhcp-types {
     prefix dhcp;
-    revision-date 2018-09-14;
+    revision-date 2018-11-11;
   }
   import kea-logging {
     prefix logging;
-    revision-date 2018-09-14;
+    revision-date 2018-11-11;
   }
 
   organization "Internet Systems Consortium";
@@ -24,7 +24,7 @@ module kea-dhcp4-server {
   description "This model defines a YANG data model that can be
                used to configure and manage a Kea DHCPv4 server.";
 
-  revision 2018-11-11 {
+  revision 2018-11-12 {
     description "Initial revision";
     reference "";
   }
@@ -60,7 +60,6 @@ module kea-dhcp4-server {
     description "Match client ID grouping.";
     leaf match-client-id {
       type boolean;
-      default true;
       description "Use client-id for lease lookups. If set to false, client-id
                    will be ignored.";
     }
@@ -350,7 +349,6 @@ module kea-dhcp4-server {
             description "DHCP service uses UDP sockets.";
           }
         }
-        default "raw";
         description "Type of sockets to use.";
       }
       leaf outbound-interface {
@@ -363,7 +361,6 @@ module kea-dhcp4-server {
             description "Use kernel routing.";
           }
         }
-        default "same-as-inbound";
         description "Control the interface used to send a response.";
       }
       uses dhcp:interfaces-re-detect;
@@ -397,7 +394,6 @@ module kea-dhcp4-server {
 
     leaf echo-client-id {
       type boolean;
-      default true;
       description "Send client-id back when the client sent it. This
                    is conformant with RFC6842, but some older, buggy
                    clients have problems with it.";
@@ -473,22 +469,18 @@ module kea-dhcp4-server {
         }
         leaf fqdn-fwd {
           type boolean;
-          default false;
           description "Lease FQDN forward flag.";
         }
         leaf fqdn-rev {
           type boolean;
-          default false;
           description "Lease FQDN reverse lag.";
         }
         leaf hostname {
           type string;
-          default "";
           description "Lease hostname.";
         }
         leaf state {
           type dhcp:lease-state;
-          default "default";
           description "Lease state.";
         }
         leaf user-context {
diff --git a/src/lib/yang/models/kea-dhcp6-server.yang b/src/lib/yang/models/kea-dhcp6-server.yang
index e398473829..0246c283c4 100644
--- a/src/lib/yang/models/kea-dhcp6-server.yang
+++ b/src/lib/yang/models/kea-dhcp6-server.yang
@@ -8,12 +8,15 @@ module kea-dhcp6-server {
   }
   import kea-types {
     prefix kea;
+    revision-date 2018-09-14;
   }
   import kea-dhcp-types {
     prefix dhcp;
+    revision-date 2018-11-11;
   }
   import kea-logging {
     prefix logging;
+    revision-date 2018-11-11;
   }
 
 
@@ -22,7 +25,7 @@ module kea-dhcp6-server {
   description "This model defines a YANG data model that can be
                used to configure and manage a Kea DHCPv6 server.";
 
-  revision 2018-09-14 {
+  revision 2018-11-12 {
     description "Initial revision";
     reference "";
   }
@@ -77,7 +80,6 @@ module kea-dhcp6-server {
     description "Rapid commit grouping.";
     leaf rapid-commit {
       type boolean;
-      default false;
       description "Rapid commit entry.";
     }
   }
@@ -423,7 +425,6 @@ module kea-dhcp6-server {
       }
       leaf persist {
         type boolean;
-        default true;
         description "Server DUID persist flag.";
       }
       leaf user-context {
@@ -528,22 +529,18 @@ module kea-dhcp6-server {
         }
         leaf fqdn-fwd {
           type boolean;
-          default false;
           description "Lease FQDN forward flag.";
         }
         leaf fqdn-rev {
           type boolean;
-          default false;
           description "Lease FQDN reverse lag.";
         }
         leaf hostname {
           type string;
-          default "";
           description "Lease hostname.";
         }
         leaf state {
           type dhcp:lease-state;
-          default "default";
           description "Lease state.";
         }
         leaf user-context {
diff --git a/src/lib/yang/models/kea-logging.yang b/src/lib/yang/models/kea-logging.yang
index 31ad29f9db..688d652c7d 100644
--- a/src/lib/yang/models/kea-logging.yang
+++ b/src/lib/yang/models/kea-logging.yang
@@ -5,6 +5,7 @@ module kea-logging {
 
   import kea-types {
     prefix kea;
+    revision-date 2018-09-14;
   }
 
   organization "Internet Systems Consortium";
@@ -12,7 +13,7 @@ module kea-logging {
   description "This model defines a YANG data model that can be
     used to configure and manage logging of a Kea server.";
 
-  revision 2018-09-14 {
+  revision 2018-11-11 {
     description "Initial revision";
     reference "";
   }
@@ -48,12 +49,10 @@ module kea-logging {
             }
             leaf flush {
               type boolean;
-              default true;
               description "When true flush buffers after each message.";
             }
             leaf maxsize {
               type uint32;
-              default 10240000;
               description "Maximum size of output file before rotation.
                 Values below 204800 including 0 disable rotation.";
             }
@@ -61,7 +60,6 @@ module kea-logging {
               type uint32 {
                 range 1..max;
               }
-              default 1;
               description "Maximum version to keep a rotated output file.";
             }
           }