From: Theodore Ts'o <tytso@mit.edu>
Date: Wed, 1 May 2024 04:20:10 +0000 (-0400)
Subject: resize2fs: mark that the error return is deliberately ignored
X-Git-Tag: v1.47.1-rc2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f3a677bfccfa34c1387336b306ab5805acf95ae;p=thirdparty%2Fe2fsprogs.git

resize2fs: mark that the error return is deliberately ignored

When moving the inode table, if writing the (partially overlapping)
inode table fails, we need to write it back in its original location
before bailing out.  If that write unding the initial write fails,
there's nothing we can do, so we ignore it.  Mark this to avoid a
false positive from Coverity.

Fixes-Coverity-bug: 1432422
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/resize/resize2fs.c b/resize/resize2fs.c
index f4a40980..e590f934 100644
--- a/resize/resize2fs.c
+++ b/resize/resize2fs.c
@@ -2595,8 +2595,8 @@ static errcode_t move_itables(ext2_resize_t rfs)
 		retval = io_channel_write_blk64(fs->io, new_blk,
 						num, rfs->itable_buf);
 		if (retval) {
-			io_channel_write_blk64(fs->io, old_blk,
-					       num, rfs->itable_buf);
+			(void) io_channel_write_blk64(fs->io, old_blk,
+						      num, rfs->itable_buf);
 			goto errout;
 		}
 		if (n > diff) {