From: Stefan Metzmacher Date: Wed, 29 Jan 2025 08:36:32 +0000 (+0100) Subject: auth: remove sid-filtering comment in make_user_info_dc_netlogon_validation X-Git-Tag: tevent-0.17.0~786 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f5d6e8b050d95c76f8b456725392cfc6043e476;p=thirdparty%2Fsamba.git auth: remove sid-filtering comment in make_user_info_dc_netlogon_validation sid filtering will be done at a different level... Signed-off-by: Stefan Metzmacher Reviewed-by: Jennifer Sutton --- diff --git a/auth/auth_sam_reply.c b/auth/auth_sam_reply.c index 8c0ebe5f156..94e2c8b08ee 100644 --- a/auth/auth_sam_reply.c +++ b/auth/auth_sam_reply.c @@ -747,12 +747,6 @@ NTSTATUS make_user_info_dc_netlogon_validation(TALLOC_CTX *mem_ctx, user_info_dc->num_sids++; } - /* Copy 'other' sids. We need to do sid filtering here to - prevent possible elevation of privileges. See: - - http://www.microsoft.com/windows2000/techinfo/administration/security/sidfilter.asp - */ - /* * The IDL layer would be a better place to check this, but to * guard the integer addition below, we double-check