From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 20 May 2024 15:07:54 +0000 (-0400)
Subject: don't create too many random things
X-Git-Tag: release_3_2_4~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f7f53eee4011918d5f68f793dc5dbd213e22604;p=thirdparty%2Ffreeradius-server.git

don't create too many random things
---

diff --git a/src/modules/rlm_expr/rlm_expr.c b/src/modules/rlm_expr/rlm_expr.c
index 1aad02d62d0..c5ebd344552 100644
--- a/src/modules/rlm_expr/rlm_expr.c
+++ b/src/modules/rlm_expr/rlm_expr.c
@@ -681,7 +681,7 @@ static ssize_t randstr_xlat(UNUSED void *instance, UNUSED REQUEST *request,
 			return -1;
 		}
 
-		if (number > 0) {
+		if (number > 1) {
 			number--;
 			goto redo;
 		}
diff --git a/src/tests/keywords/randstr b/src/tests/keywords/randstr
new file mode 100644
index 00000000000..6884cb08453
--- /dev/null
+++ b/src/tests/keywords/randstr
@@ -0,0 +1,16 @@
+update request {
+	&Tmp-Octets-0 := "0x%{randstr:16h}"
+	&Tmp-String-0 := "%{randstr:16h}"
+}
+
+if ("%{length:Tmp-Octets-0}" == 16) {
+	update reply {
+       		Filter-Id := "filter"
+	}
+}
+
+if ("%{length:Tmp-String-0}" == 32) {
+	update reply {
+       		Filter-Id := "filter"
+	}
+}