From: Volker Lendecke <vl@samba.org>
Date: Sun, 15 May 2022 11:20:34 +0000 (+0200)
Subject: srvsvcd: Avoid an "else" due to the early return
X-Git-Tag: talloc-2.3.4~88
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f82f01a3be1ff805b3203bc0af806db7800cc76;p=thirdparty%2Fsamba.git

srvsvcd: Avoid an "else" due to the early return

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/rpc_server/srvsvc/srv_srvsvc_nt.c b/source3/rpc_server/srvsvc/srv_srvsvc_nt.c
index 21bb7267030..20ac8ac0339 100644
--- a/source3/rpc_server/srvsvc/srv_srvsvc_nt.c
+++ b/source3/rpc_server/srvsvc/srv_srvsvc_nt.c
@@ -1970,13 +1970,13 @@ WERROR _srvsvc_NetShareSetInfo(struct pipes_struct *p,
 				     SHARE_1005_CSC_POLICY_MASK) >>
 				    SHARE_1005_CSC_POLICY_SHIFT;
 
-		if (client_csc_policy == lp_csc_policy(snum))
+		if (client_csc_policy == lp_csc_policy(snum)) {
 			return WERR_OK;
-		else {
-			csc_policy = csc_policies[client_csc_policy];
-			csc_policy_changed = true;
 		}
 
+		csc_policy = csc_policies[client_csc_policy];
+		csc_policy_changed = true;
+
 		pathname = lp_path(ctx, lp_sub, snum);
 		comment = lp_comment(ctx, lp_sub, snum);
 		type = STYPE_DISKTREE;