From: Jan Kara Date: Fri, 23 Jun 2017 22:08:46 +0000 (-0700) Subject: fs/dax.c: fix inefficiency in dax_writeback_mapping_range() X-Git-Tag: v4.11.8~46 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f83a744143d999dc89bd30277a4bc673a7dbb0d;p=thirdparty%2Fkernel%2Fstable.git fs/dax.c: fix inefficiency in dax_writeback_mapping_range() commit 1eb643d02b21412e603b42cdd96010a2ac31c05f upstream. dax_writeback_mapping_range() fails to update iteration index when searching radix tree for entries needing cache flushing. Thus each pagevec worth of entries is searched starting from the start which is inefficient and prone to livelocks. Update index properly. Link: http://lkml.kernel.org/r/20170619124531.21491-1-jack@suse.cz Fixes: 9973c98ecfda3 ("dax: add support for fsync/sync") Signed-off-by: Jan Kara Reviewed-by: Ross Zwisler Cc: Dan Williams Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/dax.c b/fs/dax.c index 285f4ab6f4986..08a793c615809 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -875,6 +875,7 @@ int dax_writeback_mapping_range(struct address_space *mapping, if (ret < 0) return ret; } + start_index = indices[pvec.nr - 1] + 1; } return 0; }