From: Andreas Schneider <asn@samba.org>
Date: Wed, 22 Oct 2025 07:36:50 +0000 (+0200)
Subject: nsswitch: Fix memory leak in wbinfo_xids_to_sids()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f9656e6e104701aa001232a5935c4c09a18a074;p=thirdparty%2Fsamba.git

nsswitch: Fix memory leak in wbinfo_xids_to_sids()

We should not allocate on the NULL context.

=================================================================
==313033==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 376 byte(s) in 1 object(s) allocated from:
    #0 0x7ff48b520b4b  (/lib64/libasan.so.8+0x120b4b) (BuildId: 388ee9ac193f74c177c6f52988d2d0dab110de41)
    #1 0x7ff48bb079d3 in _talloc_realloc ../../lib/talloc/talloc.c:2035
    #2 0x7ff48bb0824c in _talloc_realloc_array ../../lib/talloc/talloc.c:2810
    #3 0x00000021ab91 in wbinfo_xids_to_sids ../../nsswitch/wbinfo.c:1122
    #4 0x00000021ab91 in main ../../nsswitch/wbinfo.c:3065
    #5 0x7ff48842b2fa in __libc_start_call_main (/lib64/libc.so.6+0x2b2fa) (BuildId: 8523b213e7586a93ab00f6dd476418b1e521e62c)
    #6 0x7ffd3dc6866e  ([stack]+0x2066e)

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
---

diff --git a/nsswitch/wbinfo.c b/nsswitch/wbinfo.c
index 1b3fb41b2d8..39d03f7bd1b 100644
--- a/nsswitch/wbinfo.c
+++ b/nsswitch/wbinfo.c
@@ -1119,7 +1119,7 @@ static bool wbinfo_xids_to_sids(const char *arg)
 	p = arg;
 
 	while (next_token_talloc(frame, &p, &idstr, LIST_SEP)) {
-		xids = talloc_realloc(xids,
+		xids = talloc_realloc(frame,
 				      xids,
 				      struct wbcUnixId,
 				      num_xids + 1);