From: Jeremy Allison <jra@samba.org>
Date: Wed, 12 Jan 2022 18:42:48 +0000 (-0800)
Subject: s3: smbd: Add missing pop_sec_ctx() in error code path of close_directory()
X-Git-Tag: tdb-1.4.6~156
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5f9dbf3decd17129f360cbe14383cc79e20fb70b;p=thirdparty%2Fsamba.git

s3: smbd: Add missing pop_sec_ctx() in error code path of close_directory()

If delete_all_streams() fails.

Found by Andrew Walker <awalker@ixsystems.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14944

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 14 03:34:47 UTC 2022 on sn-devel-184
---

diff --git a/source3/smbd/close.c b/source3/smbd/close.c
index 610450d086f..8abd3fb3861 100644
--- a/source3/smbd/close.c
+++ b/source3/smbd/close.c
@@ -1430,6 +1430,8 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
 				DEBUG(5, ("delete_all_streams failed: %s\n",
 					  nt_errstr(status)));
 				file_free(req, fsp);
+				/* unbecome user. */
+				pop_sec_ctx();
 				return status;
 			}
 		}