From: Russell Bryant <russell@russellbryant.com>
Date: Thu, 5 May 2011 18:29:53 +0000 (+0000)
Subject: Merged revisions 317211 via svnmerge from
X-Git-Tag: 1.6.2.19-rc1~3^2~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5fa33b9e282ad615ce5c5240e9244bc94f977ae9;p=thirdparty%2Fasterisk.git

Merged revisions 317211 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r317211 | russell | 2011-05-05 13:20:29 -0500 (Thu, 05 May 2011) | 15 lines

  chan_sip: fix broken realtime peer count, fix memory leak

  This patch addresses two bugs in chan_sip:

  1) The count of realtime peers and users was off.  The increment checked the
  value of the caching option, while the decrement did not.

  2) Add a missing regfree() for a regex.

  (closes issue #19108)
  Reported by: vrban
  Patches:
        missing_regfree.patch uploaded by vrban (license 756)
        sip_object_counter.patch uploaded by vrban (license 756)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@317255 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 4dfa20c51d..3f5d648c9f 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -4886,7 +4886,7 @@ static void sip_destroy_peer(struct sip_peer *peer)
 	ast_free_ha(peer->ha);
 	if (peer->selfdestruct)
 		ast_atomic_fetchadd_int(&apeerobjs, -1);
-	else if (peer->is_realtime) {
+	else if (!ast_test_flag(&global_flags[1], SIP_PAGE2_RTCACHEFRIENDS) && peer->is_realtime) {
 		ast_atomic_fetchadd_int(&rpeerobjs, -1);
 		ast_debug(3, "-REALTIME- peer Destroyed. Name: %s. Realtime Peer objects: %d\n", peer->name, rpeerobjs);
 	} else
@@ -15607,6 +15607,7 @@ static char *sip_prune_realtime(struct ast_cli_entry *e, int cmd, struct ast_cli
 	int multi = FALSE;
 	char *name = NULL;
 	regex_t regexbuf;
+	int havepattern = 0;
 	struct ao2_iterator i;
 	static char *choices[] = { "all", "like", NULL };
 	char *cmplt;
@@ -15675,8 +15676,10 @@ static char *sip_prune_realtime(struct ast_cli_entry *e, int cmd, struct ast_cli
 	}
 
 	if (multi && name) {
-		if (regcomp(&regexbuf, name, REG_EXTENDED | REG_NOSUB))
+		if (regcomp(&regexbuf, name, REG_EXTENDED | REG_NOSUB)) {
 			return CLI_SHOWUSAGE;
+		}
+		havepattern = 1;
 	}
 
 	if (multi) {
@@ -15729,6 +15732,10 @@ static char *sip_prune_realtime(struct ast_cli_entry *e, int cmd, struct ast_cli
 		}
 	}
 
+	if (havepattern) {
+		regfree(&regexbuf);
+	}
+
 	return CLI_SUCCESS;
 }