From: Volker Lendecke <vl@sernet.de>
Date: Wed, 17 Dec 2008 17:14:09 +0000 (+0100)
Subject: Fix a valgrind error
X-Git-Tag: samba-3.3.0~156
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5fbfeb0fea3590fa6e018249527ba6994e36c882;p=thirdparty%2Fsamba.git

Fix a valgrind error

Reported by naga_kishore_kommuri@yahoo.com

Derrel, please check!

Thanks,

Volker
(cherry picked from commit 3356b95f72e26ede4ab16a12c334be90b8b1a639)
(cherry picked from commit 1117be19afb71d595ce4215e4760b18ff2e93869)
---

diff --git a/source/libsmb/libsmb_xattr.c b/source/libsmb/libsmb_xattr.c
index ea2c46953c7..49830189116 100644
--- a/source/libsmb/libsmb_xattr.c
+++ b/source/libsmb/libsmb_xattr.c
@@ -199,12 +199,13 @@ convert_sid_to_string(struct cli_state *ipc_cli,
 		return;
 	}
         
-	TALLOC_FREE(ctx);
 	/* Converted OK */
         
 	slprintf(str, sizeof(fstring) - 1, "%s%s%s",
 		 domains[0], lp_winbind_separator(),
 		 names[0]);
+
+	TALLOC_FREE(ctx);
 }
 
 /* convert a string to a SID, either numeric or username/group */