From: Josh Soref <2119212+jsoref@users.noreply.github.com>
Date: Mon, 14 Nov 2022 18:20:35 +0000 (-0500)
Subject: Drop comments in favor of job summaries
X-Git-Tag: dnsdist-1.8.0-rc3~10^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5feecd8a4a83ecec21ca54cb76edaba4d25868d6;p=thirdparty%2Fpdns.git

Drop comments in favor of job summaries

As we are no longer commenting, there will not be any confusion
between the two comments, and thus there is no real benefit in
skipping the check run for the push. At most a user will get two
failed runs instead of one.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
---

diff --git a/.github/workflows/spelling3.yml b/.github/workflows/spelling3.yml
index 40161d174a..18f8240990 100644
--- a/.github/workflows/spelling3.yml
+++ b/.github/workflows/spelling3.yml
@@ -2,17 +2,6 @@
 # spelling2.yml is blocked per https://github.com/check-spelling/check-spelling/security/advisories/GHSA-p8r9-69g4-jwqq
 name: Spell checking
 
-# Comment management is handled through a secondary job, for details see:
-# https://github.com/check-spelling/check-spelling/wiki/Feature%3A-Restricted-Permissions
-#
-# `jobs.comment-push` runs when a push is made to a repository and the `jobs.spelling` job needs to make a comment
-#   (in odd cases, it might actually run just to collapse a comment, but that's fairly rare)
-#   it needs `contents: write` in order to add a comment.
-#
-# `jobs.comment-pr` runs when a pull_request is made to a repository and the `jobs.spelling` job needs to make a comment
-#   or collapse a comment (in the case where it had previously made a comment and now no longer needs to show a comment)
-#   it needs `pull-requests: write` in order to manipulate those comments.
-
 on:
   push:
     branches:
@@ -34,7 +23,6 @@ jobs:
     name: Spell checking
     permissions:
       contents: read
-      pull-requests: read
       actions: read
       security-events: write
     outputs:
@@ -51,7 +39,6 @@ jobs:
       uses: check-spelling/check-spelling@v0.0.21
       with:
         config: .github/actions/spell-check
-        suppress_push_for_open_pull_request: 1
         checkout: true
         spell_check_this: check-spelling/spell-check-this@prerelease
         post_comment: 0
@@ -69,37 +56,3 @@ jobs:
           cspell:python/src/python/python.txt
           cspell:django/django.txt
         check_extra_dictionaries: ''
-
-  comment-push:
-    name: Report (Push)
-    # If your workflow isn't running on push, you can remove this job
-    runs-on: ubuntu-latest
-    needs: spelling
-    permissions:
-      contents: write
-    if: (success() || failure()) && needs.spelling.outputs.followup && github.event_name == 'push'
-    steps:
-    - name: comment
-      uses: check-spelling/check-spelling@v0.0.21
-      with:
-        config: .github/actions/spell-check
-        checkout: true
-        spell_check_this: check-spelling/spell-check-this@prerelease
-        task: ${{ needs.spelling.outputs.followup }}
-
-  comment-pr:
-    name: Report (PR)
-    # If you workflow isn't running on pull_request*, you can remove this job
-    runs-on: ubuntu-latest
-    needs: spelling
-    permissions:
-      pull-requests: write
-    if: (success() || failure()) && needs.spelling.outputs.followup && contains(github.event_name, 'pull_request')
-    steps:
-    - name: comment
-      uses: check-spelling/check-spelling@prerelease
-      with:
-        config: .github/actions/spell-check
-        checkout: true
-        spell_check_this: check-spelling/spell-check-this@prerelease
-        task: ${{ needs.spelling.outputs.followup }}