From: Mark Michelson Date: Thu, 30 Aug 2012 20:53:09 +0000 (+0000) Subject: Prevent crash on shutdown due to refcount error on queues container. X-Git-Tag: 10.9.0-rc1~37 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5fefc48cd8680793478d4eb37f48d677d35c6980;p=thirdparty%2Fasterisk.git Prevent crash on shutdown due to refcount error on queues container. When app_queue is unloaded, the queues container has its refcount decremented, potentially to 0. Then the taskprocessor responsible for handling device state changes is unreferenced. If the taskprocessor happens to be just about to run its task, then it will create and destroy an iterator on the queues container. This can cause the refcount on the queues container to increase to 1 and then back to 0. Going back to 0 a second time results in double frees. This failure was seen periodically in the testsuite when Asterisk would shut down. ........ Merged revisions 372089 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@372090 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/apps/app_queue.c b/apps/app_queue.c index 46bb9dcac4..763108b7e4 100644 --- a/apps/app_queue.c +++ b/apps/app_queue.c @@ -8663,8 +8663,8 @@ static int unload_module(void) queue_t_unref(q, "Done with iterator"); } ao2_iterator_destroy(&q_iter); - ao2_ref(queues, -1); devicestate_tps = ast_taskprocessor_unreference(devicestate_tps); + ao2_ref(queues, -1); ast_unload_realtime("queue_members"); return res; }