From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 8 Aug 2025 10:13:03 +0000 (+0300)
Subject: auth: Deinitialize userdb before freeing up settings
X-Git-Tag: 2.4.2~566
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ff9a8686a29c423e1fcf90f2d36af521cef6f7d;p=thirdparty%2Fdovecot%2Fcore.git

auth: Deinitialize userdb before freeing up settings

Some userdbs need the settings during deinitialization.

This was done for passdbs in 054ee6ae3b9a0ec7f669724037cca9059251b138.
---

diff --git a/src/auth/auth.c b/src/auth/auth.c
index 4981cf8534..bb6ead9141 100644
--- a/src/auth/auth.c
+++ b/src/auth/auth.c
@@ -197,11 +197,11 @@ auth_userdb_preinit(struct auth *auth, const struct auth_userdb_settings *_set)
 
 static void auth_userdb_deinit(struct auth_userdb *userdb)
 {
+	userdb_deinit(userdb->userdb);
 	if (userdb->set != &userdb_dummy_set)
 		settings_free(userdb->set);
 	settings_free(userdb->auth_set);
 	settings_free(userdb->unexpanded_post_set);
-	userdb_deinit(userdb->userdb);
 }
 
 static bool auth_passdb_list_have_verify_plain(const struct auth *auth)