From: Viktor Szakats Date: Tue, 27 Aug 2024 16:54:59 +0000 (+0200) Subject: cmake: default `CURL_DISABLE_LDAPS` to the value of `CURL_DISABLE_LDAP` X-Git-Tag: curl-8_10_0~58 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6004f96734a30c84e9061611ef04b8a79820a463;p=thirdparty%2Fcurl.git cmake: default `CURL_DISABLE_LDAPS` to the value of `CURL_DISABLE_LDAP` After this patch LDAPS is disabled by default when LDAP is manually disabled. This makes it unnecessary to disable them in sync manually just to avoid a `CMakeLists.txt` warning. Syncs behavior with `./configure`. Closes #14758 --- diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index d1098700eb..329580468e 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -299,15 +299,15 @@ jobs: macos-version-min: '10.8' - name: 'LibreSSL !ldap heimdal c-ares' install: libressl heimdal - generate: -DOPENSSL_ROOT_DIR=$(brew --prefix libressl) -DENABLE_ARES=ON -DCURL_USE_GSSAPI=ON -DGSS_ROOT_DIR=$(brew --prefix heimdal) -DCURL_DISABLE_LDAP=ON -DCURL_DISABLE_LDAPS=ON -DBUILD_EXAMPLES=ON + generate: -DOPENSSL_ROOT_DIR=$(brew --prefix libressl) -DENABLE_ARES=ON -DCURL_USE_GSSAPI=ON -DGSS_ROOT_DIR=$(brew --prefix heimdal) -DCURL_DISABLE_LDAP=ON -DBUILD_EXAMPLES=ON macos-version-min: '10.15' - name: 'wolfSSL !ldap brotli zstd' install: brotli wolfssl zstd - generate: -DCURL_USE_WOLFSSL=ON -DCURL_BROTLI=ON -DCURL_ZSTD=ON -DCURL_DISABLE_LDAP=ON -DCURL_DISABLE_LDAPS=ON + generate: -DCURL_USE_WOLFSSL=ON -DCURL_BROTLI=ON -DCURL_ZSTD=ON -DCURL_DISABLE_LDAP=ON macos-version-min: '10.15' - name: 'GnuTLS !ldap krb5' install: gnutls nettle krb5 - generate: -DCURL_USE_GNUTLS=ON -DCURL_USE_OPENSSL=OFF -DCURL_USE_GSSAPI=ON -DGSS_ROOT_DIR=$(brew --prefix krb5) -DCURL_DISABLE_LDAP=ON -DCURL_DISABLE_LDAPS=ON + generate: -DCURL_USE_GNUTLS=ON -DCURL_USE_OPENSSL=OFF -DCURL_USE_GSSAPI=ON -DGSS_ROOT_DIR=$(brew --prefix krb5) -DCURL_DISABLE_LDAP=ON macos-version-min: '10.15' exclude: - { compiler: llvm@15, build: { macos-version-min: '10.15' } } diff --git a/CMakeLists.txt b/CMakeLists.txt index fd73acb5bc..f8760fa87e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -291,7 +291,7 @@ option(CURL_DISABLE_IMAP "Disable IMAP" OFF) mark_as_advanced(CURL_DISABLE_IMAP) option(CURL_DISABLE_LDAP "Disable LDAP" OFF) mark_as_advanced(CURL_DISABLE_LDAP) -option(CURL_DISABLE_LDAPS "Disable LDAPS" OFF) +option(CURL_DISABLE_LDAPS "Disable LDAPS" ${CURL_DISABLE_LDAP}) mark_as_advanced(CURL_DISABLE_LDAPS) option(CURL_DISABLE_LIBCURL_OPTION "Disable --libcurl option from the curl tool" OFF) mark_as_advanced(CURL_DISABLE_LIBCURL_OPTION)