From: mkanat%bugzilla.org <>
Date: Sat, 29 Jul 2006 03:35:10 +0000 (+0000)
Subject: Bug 346245: attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla... 
X-Git-Tag: bugzilla-2.23.3~216
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6010f04049afc0df105efa7715e4d0631386d49c;p=thirdparty%2Fbugzilla.git

Bug 346245: attribute parameter 'johndoe@company.tld' is not a hash ref at Bugzilla/Auth/Verify.pm line 112
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wurblzap, a=myk
---

diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm
index 68a20f6dfd..952998caf7 100644
--- a/Bugzilla/Auth/Verify.pm
+++ b/Bugzilla/Auth/Verify.pm
@@ -102,7 +102,7 @@ sub create_or_update_user {
 
     # Now that we have a valid User, we need to see if any data has to be
     # updated.
-    if ($username && $user->login ne $username) {
+    if ($username && lc($user->login) ne lc($username)) {
         validate_email_syntax($username)
           || return { failure => AUTH_ERROR, error => 'auth_invalid_email',
                       details => {addr => $username} };
@@ -110,7 +110,7 @@ sub create_or_update_user {
         # placeholder, and we've already validated it, so it's safe.
         trick_taint($username);
         $dbh->do('UPDATE profiles SET login_name = ? WHERE userid = ?',
-                 $username, $user->id);
+                 undef, $username, $user->id);
     }
     if ($real_name && $user->name ne $real_name) {
         # $real_name is more than likely tainted, but we only use it