From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 9 Mar 2025 09:50:04 +0000 (+0100)
Subject: bootctl: do not print special glyphs to the log
X-Git-Tag: v258-rc1~1073^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6012a52abaa6e012b29f792182258faac3e91661;p=thirdparty%2Fsystemd.git

bootctl: do not print special glyphs to the log

The log line looked like this:
  bootctl[1457]: ! Mount point '/efi' which backs the random seed file is world accessible, which is a security hole! !
which doesn't look nice.

Also upgrade the message to error. This is something to fix.
---

diff --git a/src/bootctl/bootctl-random-seed.c b/src/bootctl/bootctl-random-seed.c
index 0c6f2e72579..2c81ee32b7a 100644
--- a/src/bootctl/bootctl-random-seed.c
+++ b/src/bootctl/bootctl-random-seed.c
@@ -40,13 +40,15 @@ static int random_seed_verify_permissions(int fd, mode_t expected_type) {
                 return 0;
 
         if (S_ISREG(expected_type))
-                log_warning("%s Random seed file '%s' is world accessible, which is a security hole! %s",
-                            glyph(GLYPH_WARNING_SIGN), full_path, glyph(GLYPH_WARNING_SIGN));
-        else {
-                assert(S_ISDIR(expected_type));
-                log_warning("%s Mount point '%s' which backs the random seed file is world accessible, which is a security hole! %s",
-                            glyph(GLYPH_WARNING_SIGN), full_path, glyph(GLYPH_WARNING_SIGN));
-        }
+                log_error("%s%sRandom seed file '%s' is world accessible, which is a security hole!%s%s",
+                          optional_glyph(GLYPH_WARNING_SIGN), optional_glyph(GLYPH_SPACE),
+                          full_path,
+                          optional_glyph(GLYPH_SPACE), optional_glyph(GLYPH_WARNING_SIGN));
+        else
+                log_error("%s%s Mount point '%s' which backs the random seed file is world accessible, which is a security hole! %s%s",
+                          optional_glyph(GLYPH_WARNING_SIGN), optional_glyph(GLYPH_SPACE),
+                          full_path,
+                          optional_glyph(GLYPH_SPACE), optional_glyph(GLYPH_WARNING_SIGN));
 
         return 1;
 }