From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 5 Dec 2014 00:45:14 +0000 (-0500)
Subject: - the refactor of the visit_alias() method in Oracle revealed
X-Git-Tag: rel_1_0_0b1~189^2~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60174146410d4ce2a17faa76cd981f558490db92;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- the refactor of the visit_alias() method in Oracle revealed
that quoting should be applied in %(name)s under with_hint.
---

diff --git a/doc/build/changelog/changelog_10.rst b/doc/build/changelog/changelog_10.rst
index 32fe4daabc..0256958b24 100644
--- a/doc/build/changelog/changelog_10.rst
+++ b/doc/build/changelog/changelog_10.rst
@@ -22,6 +22,13 @@
     series as well.  For changes that are specific to 1.0 with an emphasis
     on compatibility concerns, see :doc:`/changelog/migration_10`.
 
+    .. change::
+        :tags: bug, oracle
+
+        An alias name will be properly quoted when referred to using the
+        ``%(name)s`` token inside the :meth:`.Select.with_hint` method.
+        Previously, the Oracle backend hadn't implemented this quoting.
+
     .. change::
         :tags: feature, oracle
         :tickets: 3220
diff --git a/test/sql/test_compiler.py b/test/sql/test_compiler.py
index 9e99a947b0..428fc89860 100644
--- a/test/sql/test_compiler.py
+++ b/test/sql/test_compiler.py
@@ -2440,7 +2440,7 @@ class SelectTest(fixtures.TestBase, AssertsCompiledSQL):
                 """SELECT /*+ "QuotedName" idx1 */ "QuotedName".col1 """
                 """FROM "QuotedName" WHERE "QuotedName".col1 > :col1_1"""),
             (s7, oracle_d,
-             """SELECT /*+ SomeName idx1 */ "SomeName".col1 FROM """
+             """SELECT /*+ "SomeName" idx1 */ "SomeName".col1 FROM """
              """"QuotedName" "SomeName" WHERE "SomeName".col1 > :col1_1"""),
         ]:
             self.assert_compile(