From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 9 Apr 2021 10:50:24 +0000 (+1200)
Subject: dns_common_replace: do logging in needs_add case
X-Git-Tag: tevent-0.11.0~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=602dd50b31daa754c3123a6adc2ccd36ca1875cc;p=thirdparty%2Fsamba.git

dns_common_replace: do logging in needs_add case

The idiom is we return via goto exit.

This was evidently missed from commit
7e2b71d8f7cf7ac72022e1b15c30fc30706e8375

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dns_server/dnsserver_common.c b/source4/dns_server/dnsserver_common.c
index 30c1db6bee9..fb7ff32ce18 100644
--- a/source4/dns_server/dnsserver_common.c
+++ b/source4/dns_server/dnsserver_common.c
@@ -1055,7 +1055,7 @@ WERROR dns_common_replace(struct ldb_context *samdb,
 			goto exit;
 		}
 
-		return WERR_OK;
+		werr = WERR_OK;
 		goto exit;
 	}