From: Christos Tsantilas <christos@chtsanti.net>
Date: Fri, 9 Aug 2019 04:18:37 +0000 (+0000)
Subject: Fix parsing of certificate validator responses (#452)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6059886d569618c6ed24a7d03d6e29ae5dbebe55;p=thirdparty%2Fsquid.git

Fix parsing of certificate validator responses (#452)

If a certificate validator did not end its response with an end-of-line
or whitespace character, then Squid, while parsing the response,
accessed the bytes after the end of the buffer where the response is
stored.

This is a Measurement Factory project.
---

diff --git a/src/ssl/cert_validate_message.cc b/src/ssl/cert_validate_message.cc
index f5bd8f44ae..cabe62d89a 100644
--- a/src/ssl/cert_validate_message.cc
+++ b/src/ssl/cert_validate_message.cc
@@ -149,7 +149,7 @@ Ssl::CertValidationMsg::parseResponse(CertValidationResponse &resp, STACK_OF(X50
             return false;
         }
 
-        param = value + value_len +1;
+        param = value + value_len;
     }
 
     /*Run through parsed errors to check for errors*/