From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 20 Feb 2023 22:42:27 +0000 (+1300)
Subject: python/samba: Avoid resource leak
X-Git-Tag: talloc-2.4.1~1531
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60682e2aee47bfccb4daa07b2ad96193d1b51bd9;p=thirdparty%2Fsamba.git

python/samba: Avoid resource leak

View with 'git show -b'.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/ms_display_specifiers.py b/python/samba/ms_display_specifiers.py
index be9891d7437..ae48dce4ffb 100644
--- a/python/samba/ms_display_specifiers.py
+++ b/python/samba/ms_display_specifiers.py
@@ -176,9 +176,9 @@ def read_ms_ldif(filename):
     out = []
 
     from io import open
-    f = open(filename, "r", encoding='latin-1')
-    for entry in __read_raw_entries(f):
-        out.append(__write_ldif_one(__transform_entry(entry)))
+    with open(filename, "r", encoding='latin-1') as f:
+        for entry in __read_raw_entries(f):
+            out.append(__write_ldif_one(__transform_entry(entry)))
 
     return "\n\n".join(out) + "\n\n"