From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Sat, 15 Apr 2023 19:32:22 +0000 (+0200)
Subject: getinfo: use strdup instead of malloc + strcpy
X-Git-Tag: RELEASE_1_4_0b1~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=607558fc80b525fa5c3648155e89ae781cdd2cdc;p=thirdparty%2Fmlmmj.git

getinfo: use strdup instead of malloc + strcpy
---

diff --git a/src/do_all_the_voodoo_here.c b/src/do_all_the_voodoo_here.c
index 2d38bfc0..496924e6 100644
--- a/src/do_all_the_voodoo_here.c
+++ b/src/do_all_the_voodoo_here.c
@@ -52,20 +52,17 @@ findit(const char *line, const strlist *headers)
 void getinfo(const char *line, struct mailhdr *readhdrs)
 {
 	int i = 0;
-	size_t tokenlen, valuelen;
+	size_t tokenlen;
 
 	while(readhdrs[i].token) {
 		tokenlen = strlen(readhdrs[i].token);
 		if(strncasecmp(line, readhdrs[i].token, tokenlen) == 0) {
 			readhdrs[i].valuecount++;
-			valuelen = strlen(line) - tokenlen;
 			readhdrs[i].values =
 				(char **)xrealloc(readhdrs[i].values,
 				  readhdrs[i].valuecount * sizeof(char *));
 			readhdrs[i].values[readhdrs[i].valuecount - 1] =
-					(char *)xmalloc(valuelen + 1);
-			strcpy(readhdrs[i].values[readhdrs[i].valuecount - 1],
-						line+tokenlen);
+				xstrdup(line + tokenlen);
 		}
 		i++;
 	}