From: Vladimir Serbinenko <phcoder@gmail.com>
Date: Sat, 24 Jan 2015 20:25:42 +0000 (+0100)
Subject: commands/tr: Simplify and fix missing parameter test.
X-Git-Tag: 2.02-beta3~527
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6079e67926079d4b3ca35aa570eee2c0f4459f04;p=thirdparty%2Fgrub.git

commands/tr: Simplify and fix missing parameter test.

Found by: Coverity scan
---

diff --git a/grub-core/commands/tr.c b/grub-core/commands/tr.c
index 84ad6ff8f..ef72841a2 100644
--- a/grub-core/commands/tr.c
+++ b/grub-core/commands/tr.c
@@ -80,7 +80,7 @@ grub_cmd_tr (grub_extcmd_context_t ctxt, int argc, char **args)
   } else if (argc > 3)
     return grub_error (GRUB_ERR_BAD_ARGUMENT, "too many parameters");
 
-  if (argc <= 0 && (!s1 || !s2 || !input))
+  if (!s1 || !s2 || !input)
     return grub_error (GRUB_ERR_BAD_ARGUMENT, "missing parameters");
 
   if (grub_strlen (s1) != grub_strlen (s2))