From: Alex Morega <alex@grep.ro>
Date: Fri, 5 Jul 2013 13:53:26 +0000 (+0200)
Subject: simplify try-except-close for output file
X-Git-Tag: 1.0~116^2~1^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60917d2de26760c579c51da9774dce394b6b35d5;p=thirdparty%2Fbabel.git

simplify try-except-close for output file
---

diff --git a/babel/messages/frontend.py b/babel/messages/frontend.py
index 90d01a45..753151eb 100755
--- a/babel/messages/frontend.py
+++ b/babel/messages/frontend.py
@@ -881,11 +881,6 @@ class CommandLineInterface(object):
         if not args:
             parser.error('incorrect number of arguments')
 
-        if options.output not in (None, '-'):
-            outfile = open(options.output, 'w')
-        else:
-            outfile = sys.stdout
-
         keywords = DEFAULT_KEYWORDS.copy()
         if options.no_default_keywords:
             if not options.keywords:
@@ -914,47 +909,53 @@ class CommandLineInterface(object):
             parser.error("'--sort-output' and '--sort-by-file' are mutually "
                          "exclusive")
 
-        try:
-            catalog = Catalog(project=options.project,
-                              version=options.version,
-                              msgid_bugs_address=options.msgid_bugs_address,
-                              copyright_holder=options.copyright_holder,
-                              charset=options.charset)
-
-            for dirname in args:
-                if not os.path.isdir(dirname):
-                    parser.error('%r is not a directory' % dirname)
-
-                def callback(filename, method, options):
-                    if method == 'ignore':
-                        return
-                    filepath = os.path.normpath(os.path.join(dirname, filename))
-                    optstr = ''
-                    if options:
-                        optstr = ' (%s)' % ', '.join(['%s="%s"' % (k, v) for
-                                                      k, v in options.items()])
-                    self.log.info('extracting messages from %s%s', filepath,
-                                  optstr)
+        catalog = Catalog(project=options.project,
+                          version=options.version,
+                          msgid_bugs_address=options.msgid_bugs_address,
+                          copyright_holder=options.copyright_holder,
+                          charset=options.charset)
+
+        for dirname in args:
+            if not os.path.isdir(dirname):
+                parser.error('%r is not a directory' % dirname)
+
+            def callback(filename, method, options):
+                if method == 'ignore':
+                    return
+                filepath = os.path.normpath(os.path.join(dirname, filename))
+                optstr = ''
+                if options:
+                    optstr = ' (%s)' % ', '.join(['%s="%s"' % (k, v) for
+                                                  k, v in options.items()])
+                self.log.info('extracting messages from %s%s', filepath,
+                              optstr)
+
+            extracted = extract_from_dir(dirname, method_map, options_map,
+                                         keywords, options.comment_tags,
+                                         callback=callback,
+                                         strip_comment_tags=
+                                            options.strip_comment_tags)
+            for filename, lineno, message, comments, context in extracted:
+                filepath = os.path.normpath(os.path.join(dirname, filename))
+                catalog.add(message, None, [(filepath, lineno)],
+                            auto_comments=comments, context=context)
 
-                extracted = extract_from_dir(dirname, method_map, options_map,
-                                             keywords, options.comment_tags,
-                                             callback=callback,
-                                             strip_comment_tags=
-                                                options.strip_comment_tags)
-                for filename, lineno, message, comments, context in extracted:
-                    filepath = os.path.normpath(os.path.join(dirname, filename))
-                    catalog.add(message, None, [(filepath, lineno)],
-                                auto_comments=comments, context=context)
+        if options.output not in (None, '-'):
+            self.log.info('writing PO template file to %s' % options.output)
+            outfile = open(options.output, 'w')
+            close_output = True
+        else:
+            outfile = sys.stdout
+            close_output = False
 
-            if options.output not in (None, '-'):
-                self.log.info('writing PO template file to %s' % options.output)
+        try:
             write_po(outfile, catalog, width=options.width,
                      no_location=options.no_location,
                      omit_header=options.omit_header,
                      sort_output=options.sort_output,
                      sort_by_file=options.sort_by_file)
         finally:
-            if options.output:
+            if close_output:
                 outfile.close()
 
     def init(self, argv):