From: Marc Schumann <wurblzap@gmail.com>
Date: Mon, 26 May 2014 08:02:30 +0000 (+0200)
Subject: Bug 1015173: Groups report all members as being direct members.
X-Git-Tag: bugzilla-4.5.5~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60965ea037f9709acd9aa9cc415b423f20345a84;p=thirdparty%2Fbugzilla.git

Bug 1015173: Groups report all members as being direct members.
r=gerv, a=glob
---

diff --git a/Bugzilla/Group.pm b/Bugzilla/Group.pm
index 58c9ea19d1..965fa226f9 100644
--- a/Bugzilla/Group.pm
+++ b/Bugzilla/Group.pm
@@ -95,7 +95,8 @@ sub members_non_inherited {
 sub _get_members {
     my ($self, $grant_type) = @_;
     my $dbh = Bugzilla->dbh;
-    my $grant_clause = $grant_type ? "AND grant_type = $grant_type" : "";
+    my $grant_clause = defined($grant_type) ? "AND grant_type = $grant_type"
+                                            : "";
     my $user_ids = $dbh->selectcol_arrayref(
         "SELECT DISTINCT user_id
            FROM user_group_map