From: JINMEI Tatuya <jinmei@isc.org>
Date: Mon, 5 Nov 2012 23:59:10 +0000 (-0800)
Subject: [2372] handle the case of comment after '('
X-Git-Tag: trac2487_base~1^2~21^2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60977cf7528acb2bcc00067cb6a88a8136445453;p=thirdparty%2Fkea.git

[2372] handle the case of comment after '('
---

diff --git a/src/lib/dns/tests/master_lexer_state_unittest.cc b/src/lib/dns/tests/master_lexer_state_unittest.cc
index 2c7570ec5b..00a57143b4 100644
--- a/src/lib/dns/tests/master_lexer_state_unittest.cc
+++ b/src/lib/dns/tests/master_lexer_state_unittest.cc
@@ -142,8 +142,6 @@ TEST_F(MasterLexerStateTest, parentheses) {
     EXPECT_EQ(Token::END_OF_LINE, s_start.getToken(lexer).getType());
     EXPECT_EQ(s_null, s_start.handle(lexer));
     EXPECT_EQ(Token::INITIAL_WS, s_start.getToken(lexer).getType());
-
-    // TBD: Test case: '(;'
 }
 
 TEST_F(MasterLexerStateTest, nestedParentheses) {
@@ -215,4 +213,15 @@ TEST_F(MasterLexerStateTest, startToComment) {
     EXPECT_EQ(Token::END_OF_FILE, s_start.getToken(lexer).getType());
 }
 
+TEST_F(MasterLexerStateTest, commentAfterParen) {
+    // comment after an opening parenthesis.  The code that is tested by
+    // other tests should also ensure that it works correctly, but we
+    // check it explicitly.
+    ss << "( ;this is a comment\na)\n";
+    EXPECT_EQ(&s_string, s_start.handle(lexer)); // consume '(', skip comments
+    s_string.handle(lexer);                      // consume 'a'
+    EXPECT_EQ(s_null, s_start.handle(lexer));    // consume ')', see '\n'
+    EXPECT_EQ(Token::END_OF_LINE, s_start.getToken(lexer).getType());
+}
+
 }