From: jocuri%softhome.net <>
Date: Tue, 21 Feb 2006 22:36:42 +0000 (+0000)
Subject: Patch for bug 287325: we should use scalar instead of length for finding out how... 
X-Git-Tag: bugzilla-2.23.1~169
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60b9162729b1c13bb8bbe552f9b62b267035e2d4;p=thirdparty%2Fbugzilla.git

Patch for bug 287325: we should use scalar instead of length for finding out how many elements an array has; patch by me, r=justdave on IRC, fixing tree.
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 22f62f1864..290c4e7ca8 100755
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -128,7 +128,7 @@ sub initBug  {
   $self->{'who'} = new Bugzilla::User($user_id);
 
     my $custom_fields = "";
-    if (length(Bugzilla->custom_field_names) > 0) {
+    if (scalar(Bugzilla->custom_field_names) > 0) {
         $custom_fields = ", " . join(", ", Bugzilla->custom_field_names);
     }
 
@@ -742,7 +742,6 @@ sub AppendComment {
     $dbh->do("UPDATE bugs SET delta_ts = ? WHERE bug_id = ?",
              undef, $timestamp, $bugid);
 }
-
 # This method is private and is not to be used outside of the Bug class.
 sub EmitDependList {
     my ($myfield, $targetfield, $bug_id) = (@_);