From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 14 Jul 2023 14:13:06 +0000 (-0600)
Subject: Revert "assert that the channel has no running requests before ACK close"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60c007f383fcb63c9ad0dbaf69447b6e86872c0f;p=thirdparty%2Ffreeradius-server.git

Revert "assert that the channel has no running requests before ACK close"

This reverts commit bdec27409cda11b9432c583748bfac69241a118b.
---

diff --git a/src/lib/io/worker.c b/src/lib/io/worker.c
index 7f01872957c..bc722fcf1df 100644
--- a/src/lib/io/worker.c
+++ b/src/lib/io/worker.c
@@ -334,8 +334,6 @@ static void worker_channel_callback(void *ctx, void const *data, size_t data_siz
 			fr_assert_msg(fr_dlist_num_elements(&worker->channel[i].dlist) == 0,
 				      "Network added messages to channel after sending FR_CHANNEL_CLOSE");
 
-			fr_assert(fr_dlist_num_elements(&worker->channel[i].dlist) == 0);
-
 			fr_channel_responder_ack_close(ch);
 			fr_assert(ms != NULL);
 			fr_message_set_gc(ms);
@@ -1039,8 +1037,6 @@ void fr_worker_destroy(fr_worker_t *worker)
 	}
 	fr_assert(fr_heap_num_elements(worker->runnable) == 0);
 
-	///
-
 	/*
 	 *	Signal the channels that we're closing.
 	 *
@@ -1058,9 +1054,6 @@ void fr_worker_destroy(fr_worker_t *worker)
 		fr_assert_msg(fr_dlist_num_elements(&worker->channel[i].dlist) == 0,
 			      "Pending messages in channel after cancelling request");
 
-		worker_requests_cancel(&worker->channel[i]);
-
-		fr_assert(fr_dlist_num_elements(&worker->channel[i].dlist) == 0);
 		fr_channel_responder_ack_close(worker->channel[i].ch);
 	}