From: VMware, Inc <>
Date: Mon, 22 Aug 2011 20:27:38 +0000 (-0700)
Subject: Remove VIX_BACKDOORCOMMAND_CHECK_USER_ACCOUNT command.
X-Git-Tag: 2011.08.21-471295~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60e89354668c25059dc87cf92a373cd32f9bb13e;p=thirdparty%2Fopen-vm-tools.git

Remove VIX_BACKDOORCOMMAND_CHECK_USER_ACCOUNT command.

We have a backdoor command i.e. VIX_BACKDOORCOMMAND_CHECK_USER_ACCOUNT but
is not used anywhere in the code. VMX forwards "check user account" commands
through backdoor using VIX_BACKDOORCOMMAND_COMMAND.

I have removed the code that is related to
VIX_BACKDOORCOMMAND_CHECK_USER_ACCOUNT.

Signed-off-by: Marcelo Vanzin <mvanzin@vmware.com>
---

diff --git a/open-vm-tools/lib/include/vixCommands.h b/open-vm-tools/lib/include/vixCommands.h
index e661e44cc..572bef938 100644
--- a/open-vm-tools/lib/include/vixCommands.h
+++ b/open-vm-tools/lib/include/vixCommands.h
@@ -2289,7 +2289,6 @@ enum {
 #define VIX_BACKDOORCOMMAND_SYNCDRIVER_FREEZE      VIX_BACKDOOR_COMMAND_VERSION"SyncDriver_Freeze"
 #define VIX_BACKDOORCOMMAND_SYNCDRIVER_THAW        VIX_BACKDOOR_COMMAND_VERSION"SyncDriver_Thaw"
 #define VIX_BACKDOORCOMMAND_GET_PROPERTIES         VIX_BACKDOOR_COMMAND_VERSION"Get_ToolsProperties"
-#define VIX_BACKDOORCOMMAND_CHECK_USER_ACCOUNT     VIX_BACKDOOR_COMMAND_VERSION"Check_User_Account"
 #define VIX_BACKDOORCOMMAND_SEND_HGFS_PACKET       VIX_BACKDOOR_COMMAND_VERSION"Send_Hgfs_Packet"
 #define VIX_BACKDOORCOMMAND_UNRECOGNIZED_COMMAND   VIX_BACKDOOR_COMMAND_VERSION"Unrecognized_Command"
 #define VIX_BACKDOORCOMMAND_COMMAND                VIX_BACKDOOR_COMMAND_VERSION"Relayed_Command"
diff --git a/open-vm-tools/services/plugins/vix/foundryToolsDaemon.c b/open-vm-tools/services/plugins/vix/foundryToolsDaemon.c
index efdbbfa84..b6febea1a 100644
--- a/open-vm-tools/services/plugins/vix/foundryToolsDaemon.c
+++ b/open-vm-tools/services/plugins/vix/foundryToolsDaemon.c
@@ -345,85 +345,6 @@ abort:
 } // FoundryToolsDaemonGetToolsProperties
 
 
-/*
- *-----------------------------------------------------------------------------
- *
- * ToolsDaemonTcloCheckUserAccount --
- *
- *
- * Return value:
- *    TRUE on success
- *    FALSE on failure
- *
- * Side effects:
- *    None
- *
- *-----------------------------------------------------------------------------
- */
-
-gboolean
-ToolsDaemonTcloCheckUserAccount(RpcInData *data) // IN
-{
-   VixError err = VIX_OK;
-   char *credentialTypeStr = NULL;
-   char *obfuscatedNamePassword = NULL;
-   static char resultBuffer[DEFAULT_RESULT_MSG_MAX_LENGTH];
-   Bool impersonatingVMWareUser = FALSE;
-   void *userToken = NULL;
-   Debug(">ToolsDaemonTcloCheckUserAccount\n");
-
-   /*
-    * Parse the argument
-    */
-   credentialTypeStr = ToolsDaemonTcloGetQuotedString(data->args, &data->args);
-   obfuscatedNamePassword = ToolsDaemonTcloGetQuotedString(data->args, &data->args);
-
-   /*
-    * Make sure we are passed the correct arguments.
-    */
-   if ((NULL == credentialTypeStr) || (NULL == obfuscatedNamePassword)) {
-      err = VIX_E_INVALID_ARG;
-      goto abort;
-   }
-
-   if (thisProcessRunsAsRoot) {
-      impersonatingVMWareUser = VixToolsImpersonateUserImpl(credentialTypeStr, 
-                                                            VIX_USER_CREDENTIAL_NONE,
-                                                            obfuscatedNamePassword, 
-                                                            &userToken);
-      if (!impersonatingVMWareUser) {
-         err = VIX_E_GUEST_USER_PERMISSIONS;
-         goto abort;
-      }
-   }
-
-abort:
-   if (impersonatingVMWareUser) {
-      VixToolsUnimpersonateUser(userToken);
-   }
-   VixToolsLogoutUser(userToken);
-
-   /*
-    * All VMXI tools commands return results that start with a VMXI error
-    * and a guest-OS-specific error.
-    */
-   Str_Sprintf(resultBuffer,
-               sizeof(resultBuffer),
-               "%"FMT64"d %d",
-               err,
-               Err_Errno());
-   RPCIN_SETRETVALS(data, resultBuffer, TRUE);
-
-   /*
-    * These were allocated by ToolsDaemonTcloGetQuotedString.
-    */
-   free(credentialTypeStr);
-   free(obfuscatedNamePassword);
-
-   return TRUE;
-} // ToolsDaemonTcloCheckUserAccount
-
-
 /**
  * Initializes internal state of the Foundry daemon.
  *
diff --git a/open-vm-tools/services/plugins/vix/vixPlugin.c b/open-vm-tools/services/plugins/vix/vixPlugin.c
index f8438b7ab..20ed570a2 100644
--- a/open-vm-tools/services/plugins/vix/vixPlugin.c
+++ b/open-vm-tools/services/plugins/vix/vixPlugin.c
@@ -77,8 +77,6 @@ ToolsOnLoad(ToolsAppCtx *ctx)
          FoundryToolsDaemonRunProgram, NULL, NULL, NULL, 0 },
       { VIX_BACKDOORCOMMAND_GET_PROPERTIES,
          FoundryToolsDaemonGetToolsProperties, NULL, NULL, 0 },
-      { VIX_BACKDOORCOMMAND_CHECK_USER_ACCOUNT,
-         ToolsDaemonTcloCheckUserAccount, NULL, NULL, NULL, 0 },
       { VIX_BACKDOORCOMMAND_SEND_HGFS_PACKET,
          ToolsDaemonHgfsImpersonated, NULL, NULL, NULL, 0 },
       { VIX_BACKDOORCOMMAND_COMMAND,
diff --git a/open-vm-tools/services/plugins/vix/vixPluginInt.h b/open-vm-tools/services/plugins/vix/vixPluginInt.h
index 107f0f8bd..01b9752ab 100644
--- a/open-vm-tools/services/plugins/vix/vixPluginInt.h
+++ b/open-vm-tools/services/plugins/vix/vixPluginInt.h
@@ -36,9 +36,6 @@ FoundryToolsDaemon_Initialize(ToolsAppCtx *ctx);
 void
 FoundryToolsDaemon_Uninitialize(ToolsAppCtx *ctx);
 
-gboolean
-ToolsDaemonTcloCheckUserAccount(RpcInData *data);
-
 gboolean
 FoundryToolsDaemonGetToolsProperties(RpcInData *data);