From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 17 Jul 2023 03:48:50 +0000 (+1200)
Subject: libcli/security: Remove unnecessary code
X-Git-Tag: tevent-0.16.0~1238
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60f4d873b7501bf0b59ad152fd19c0212e637e6b;p=thirdparty%2Fsamba.git

libcli/security: Remove unnecessary code

The revision has already been set at the start of this function.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index e14b2748384..022d20917b2 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -587,16 +587,6 @@ static struct security_acl *sddl_decode_acl(struct security_descriptor *sd,
 			talloc_free(acl);
 			return NULL;
 		}
-		switch (acl->aces[acl->num_aces].type) {
-		case SEC_ACE_TYPE_ACCESS_ALLOWED_OBJECT:
-		case SEC_ACE_TYPE_ACCESS_DENIED_OBJECT:
-		case SEC_ACE_TYPE_SYSTEM_AUDIT_OBJECT:
-		case SEC_ACE_TYPE_SYSTEM_ALARM_OBJECT:
-			acl->revision = SECURITY_ACL_REVISION_ADS;
-			break;
-		default:
-			break;
-		}
 		talloc_free(astr);
 		sddl += len+2;
 		acl->num_aces++;