From: Willy Tarreau <w@1wt.eu>
Date: Tue, 17 Oct 2017 06:19:21 +0000 (+0200)
Subject: MINOR: h2: handle CONTINUATION frames
X-Git-Tag: v1.8-rc1~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=61290ec774b311edad0285b90fab979a420d252c;p=thirdparty%2Fhaproxy.git

MINOR: h2: handle CONTINUATION frames

For now we have nowhere to store partial header frames so we can't
handle CONTINUATION frames and we must reject them. In this case we
respond with a stream error of type INTERNAL_ERROR.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 72a4b507e8..7d828b1407 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -1204,6 +1204,15 @@ static void h2_process_demux(struct h2c *h2c)
 				ret = h2c_handle_window_update(h2c, h2s);
 			break;
 
+		case H2_FT_CONTINUATION:
+			/* we currently don't support CONTINUATION frames since
+			 * we have nowhere to store the partial HEADERS frame.
+			 * Let's abort the stream on an INTERNAL_ERROR here.
+			 */
+			if (h2c->st0 == H2_CS_FRAME_P)
+				h2s_error(h2s, H2_ERR_INTERNAL_ERROR);
+			break;
+
 			/* FIXME: implement all supported frame types here */
 		default:
 			/* drop frames that we ignore. They may be larger than