From: Michael Schroeder Date: Tue, 13 Dec 2022 09:01:35 +0000 (+0100) Subject: Make get_decision also return a decision for unrelated solvables X-Git-Tag: 0.7.23~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=613c7a60175b8e1e5a819a9a8db0f2b7057c4d07;p=thirdparty%2Flibsolv.git Make get_decision also return a decision for unrelated solvables Consistency with get_decisionlist(). --- diff --git a/bindings/solv.i b/bindings/solv.i index de53ab83..5d82832b 100644 --- a/bindings/solv.i +++ b/bindings/solv.i @@ -3733,13 +3733,14 @@ returnself(matchsolvable) return solver_create_transaction($self); } + /* legacy, use get_decision */ int describe_decision(XSolvable *s, XRule **OUTPUT) { Id ruleid; int reason = solver_describe_decision($self, s->id, &ruleid); *OUTPUT = new_XRule($self, ruleid); return reason; } - + /* legacy, use get_decision and the info/allinfos method */ %newobject describe_weakdep_decision_raw; Queue describe_weakdep_decision_raw(XSolvable *s) { Queue q; @@ -3861,13 +3862,10 @@ rb_eval_string( %newobject get_decision; Decision *get_decision(XSolvable *s) { - Id info, p; - int reason; + Id info; int lvl = solver_get_decisionlevel($self, s->id); - if (!lvl) - return 0; - p = lvl > 0 ? s->id : -s->id; - reason = solver_describe_decision($self, p, &info); + Id p = lvl > 0 ? s->id : -s->id; + int reason = solver_describe_decision($self, p, &info); return new_Decision($self, p, reason, info); }