From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 6 Oct 2023 01:10:09 +0000 (+1300)
Subject: s4:libcli: Check return value of convert_string_talloc() (CID 1272839)
X-Git-Tag: tevent-0.16.0~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=61534dd22d91dd9d47453c82371016bf45ecb4e1;p=thirdparty%2Fsamba.git

s4:libcli: Check return value of convert_string_talloc() (CID 1272839)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/libcli/ldap/ldap_controls.c b/source4/libcli/ldap/ldap_controls.c
index aee68ab2022..f8d82bab839 100644
--- a/source4/libcli/ldap/ldap_controls.c
+++ b/source4/libcli/ldap/ldap_controls.c
@@ -499,9 +499,14 @@ static bool encode_verify_name_request(void *mem_ctx, void *in, DATA_BLOB *out)
 	}
 
 	if (lvnc->gc_len) {
-		convert_string_talloc(mem_ctx, CH_UNIX, CH_UTF16,
-						lvnc->gc, lvnc->gc_len,
-						&gc_utf16.data, &gc_utf16.length);
+		bool ok;
+
+		ok = convert_string_talloc(mem_ctx, CH_UNIX, CH_UTF16,
+					   lvnc->gc, lvnc->gc_len,
+					   &gc_utf16.data, &gc_utf16.length);
+		if (!ok) {
+			return false;
+		}
 		if (!asn1_write_OctetString(data, gc_utf16.data, gc_utf16.length)) {
 			return false;
 		}