From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Fri, 21 Apr 2023 11:40:21 +0000 (+0200)
Subject: Add MakeInitrd=
X-Git-Tag: v15~220
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=616adf54ef01e8034b6d73701de75fca5860dcc6;p=thirdparty%2Fmkosi.git

Add MakeInitrd=

Instead of automatically making cpio's initrds, let's put this behind
a MakeInitrd= option. This allows booting directly into cpios with systemd
when they're not configured as an initramfs.
---

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e42ab21db..bc6a94dc6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -174,7 +174,7 @@ jobs:
     - name: Build ${{ matrix.distro }} initrd
       if: matrix.prebuilt-initrd == 'yes'
       # Run the build in .github/workflows/ so we don't pick up any of the configuration files in .github/
-      run: python3 -m mkosi -d ${{ matrix.distro }} -t cpio -p systemd -p udev -p kmod -o $PWD/initrd build
+      run: python3 -m mkosi -d ${{ matrix.distro }} -t cpio -p systemd -p udev -p kmod --make-initrd -o $PWD/initrd build
       working-directory: ./.github/workflows
 
     - name: Configure ${{ matrix.distro }}/${{ matrix.format }}
diff --git a/mkosi.md b/mkosi.md
index 39230ebc3..ddc778605 100644
--- a/mkosi.md
+++ b/mkosi.md
@@ -798,6 +798,11 @@ a boolean argument: either "1", "yes", or "true" to enable, or "0",
   files. This option may be used multiple times in which case the initrd lists
   are combined.
 
+`MakeInitrd=`, `--make-initrd`
+
+: Add `/etc/initrd-release` and `/init` to the image so that it can be
+  used as an initramfs.
+
 ### [Validation] Section
 
 `Checksum=`, `--checksum`
diff --git a/mkosi/__init__.py b/mkosi/__init__.py
index a633c2686..ddeda244f 100644
--- a/mkosi/__init__.py
+++ b/mkosi/__init__.py
@@ -1567,7 +1567,7 @@ def configure_ssh(state: MkosiState) -> None:
 
 
 def configure_initrd(state: MkosiState) -> None:
-    if state.for_cache or not state.config.output_format == OutputFormat.cpio:
+    if state.for_cache or not state.config.make_initrd:
         return
 
     if not state.root.joinpath("init").exists():
diff --git a/mkosi/backend.py b/mkosi/backend.py
index 79ef02e40..baedc7ac5 100644
--- a/mkosi/backend.py
+++ b/mkosi/backend.py
@@ -277,6 +277,7 @@ class MkosiConfig:
     auto_bump: bool
     workspace_dir: Optional[Path]
     initrds: list[Path]
+    make_initrd: bool
     kernel_command_line_extra: list[str]
     acl: bool
     pager: bool
diff --git a/mkosi/config.py b/mkosi/config.py
index 641d492ba..64681c2a6 100644
--- a/mkosi/config.py
+++ b/mkosi/config.py
@@ -665,6 +665,11 @@ class MkosiConfigParser:
             section="Content",
             parse=config_make_list_parser(delimiter=",", parse=make_path_parser(required=False)),
         ),
+        MkosiConfigSetting(
+            dest="make_initrd",
+            section="Content",
+            parse=config_parse_boolean,
+        ),
         MkosiConfigSetting(
             dest="checksum",
             section="Validation",
@@ -1255,6 +1260,13 @@ class MkosiConfigParser:
             dest="initrds",
             action=action,
         )
+        group.add_argument(
+            "--make-initrd",
+            help="Make sure the image can be used as an initramfs",
+            metavar="BOOL",
+            nargs="?",
+            action=action,
+        )
 
         group = parser.add_argument_group("Validation options")
         group.add_argument(