From: Philippe Antoine <pantoine@oisf.net>
Date: Thu, 16 Jun 2022 08:58:42 +0000 (+0200)
Subject: fuzz: remove check about max transactions
X-Git-Tag: suricata-7.0.0-beta1~271
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=617c9fb7e5f4cde2184f730b8e4e478d2c9983c8;p=thirdparty%2Fsuricata.git

fuzz: remove check about max transactions

Suricata can indeed pipeline many HTTP1 transactions
---

diff --git a/src/tests/fuzz/fuzz_applayerparserparse.c b/src/tests/fuzz/fuzz_applayerparserparse.c
index b1bfdbdee1..a7c7653673 100644
--- a/src/tests/fuzz/fuzz_applayerparserparse.c
+++ b/src/tests/fuzz/fuzz_applayerparserparse.c
@@ -170,31 +170,6 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
             }
 
             AppLayerParserTransactionsCleanup(f);
-
-            if (f->alstate && f->alparser) {
-                // check if we have too many open transactions
-                const uint64_t total_txs = AppLayerParserGetTxCnt(f, f->alstate);
-                uint64_t min = 0;
-                AppLayerGetTxIterState state;
-                memset(&state, 0, sizeof(state));
-                uint64_t nbtx = 0;
-                AppLayerGetTxIteratorFunc IterFunc = AppLayerGetTxIterator(f->proto, f->alproto);
-                while (1) {
-                    AppLayerGetTxIterTuple ires =
-                            IterFunc(f->proto, f->alproto, f->alstate, min, total_txs, &state);
-                    if (ires.tx_ptr == NULL)
-                        break;
-                    min = ires.tx_id + 1;
-                    nbtx++;
-                    if (nbtx > ALPROTO_MAXTX) {
-                        printf("Too many open transactions for protocol %s\n",
-                                AppProtoToString(f->alproto));
-                        printf("Assertion failure: %s\n", AppProtoToString(f->alproto));
-                        fflush(stdout);
-                        abort();
-                    }
-                }
-            }
         }
         alsize -= alnext - albuffer + 4;
         albuffer = alnext + 4;