From: Victor Julien <victor@inliniac.net>
Date: Thu, 5 Dec 2019 14:31:28 +0000 (+0100)
Subject: app-layer: optimize inspection id tracking
X-Git-Tag: suricata-5.0.1~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=618ad0d92fccb2a4bd6489e76b695d661da82dd1;p=thirdparty%2Fsuricata.git

app-layer: optimize inspection id tracking

Increase the inspect id for a completely inspected tx in any case.
This avoids re-evaluating transactions.

Reported-by: Ilya Bakhtin
---

diff --git a/src/app-layer-parser.c b/src/app-layer-parser.c
index b7de5c0f40..660289e66d 100644
--- a/src/app-layer-parser.c
+++ b/src/app-layer-parser.c
@@ -795,9 +795,9 @@ void AppLayerParserSetTransactionInspectId(const Flow *f, AppLayerParserState *p
                         tx, idx, flags & STREAM_TOSERVER ? "toserver" : "toclient", detect_flags);
             }
         }
+        idx++;
         if (!ires.has_next)
             break;
-        idx++;
     }
     pstate->inspect_id[direction] = idx;
     SCLogDebug("inspect_id now %"PRIu64, pstate->inspect_id[direction]);