From: Florian Weimer <fweimer@redhat.com>
Date: Mon, 2 Dec 2019 13:53:16 +0000 (+0100)
Subject: elf/tst-dlopenfail: Disable --no-as-needed for tst-dlopenfailmod1.so
X-Git-Tag: glibc-2.31~191
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=61a7c9df71ee4e6f94b56c20f0d37c6e17d5f284;p=thirdparty%2Fglibc.git

elf/tst-dlopenfail: Disable --no-as-needed for tst-dlopenfailmod1.so

Otherwise, the shared object dependency which triggers the load
failure is dropped, invalidating the test.
---

diff --git a/elf/Makefile b/elf/Makefile
index 305bed2d38e..f7adebec880 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -1602,8 +1602,11 @@ LDFLAGS-tst-finilazyfailmod.so = \
 $(objpfx)tst-dlopenfail: $(libdl)
 $(objpfx)tst-dlopenfail.out: \
   $(objpfx)tst-dlopenfailmod1.so $(objpfx)tst-dlopenfailmod2.so
-# Order matters here.  tst-dlopenfaillinkmod.so's soname ensures
-# a run-time loader failure.
+# Order matters here.  tst-dlopenfaillinkmod.so's soname ensures a
+# run-time loader failure.  --as-needed breaks this test because
+# nothing actually references tst-dlopenfailmod2.so (with its soname
+# tst-dlopenfail-missingmod.so).
+LDFLAGS-tst-dlopenfailmod1.so = -Wl,--no-as-needed
 $(objpfx)tst-dlopenfailmod1.so: \
   $(shared-thread-library) $(objpfx)tst-dlopenfaillinkmod.so
 LDFLAGS-tst-dlopenfaillinkmod.so = -Wl,-soname,tst-dlopenfail-missingmod.so