From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 14 Mar 2013 00:57:52 +0000 (-0400)
Subject: More fixes for Coverity.
X-Git-Tag: release_3_0_0_beta1~758
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=61c8d6570ad93d20ea4439a181329e71d1dd0d03;p=thirdparty%2Ffreeradius-server.git

More fixes for Coverity.

It can't tell that dict_attrunknown always returns type=octets
---

diff --git a/src/lib/radius.c b/src/lib/radius.c
index 4baf3525400..a51be5c837a 100644
--- a/src/lib/radius.c
+++ b/src/lib/radius.c
@@ -3455,6 +3455,15 @@ static ssize_t data2vp(const RADIUS_PACKET *packet,
 			return -1;
 		}
 		tag = 0;
+#ifndef NDEBUG
+		/*
+		 *	Fix for Coverity.
+		 */
+		if (da->type != PW_TYPE_OCTETS) {
+			dict_attr_free(&da);
+			return -1;
+		}
+#endif
 		break;
 	}