From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 19 Oct 2017 14:29:35 +0000 (-0400)
Subject: child created detachable is always detachable
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=61dff967ed4d7351b161ddbfebfb3d89dbc3c123;p=thirdparty%2Ffreeradius-server.git

child created detachable is always detachable
---

diff --git a/src/main/unlang_interpret.c b/src/main/unlang_interpret.c
index cb6f17a73fd..1b3f3e54865 100644
--- a/src/main/unlang_interpret.c
+++ b/src/main/unlang_interpret.c
@@ -882,7 +882,7 @@ static unlang_action_t unlang_subrequest(REQUEST *request,
 	 */
 	rcode = unlang_run(child);
 	if (rcode != RLM_MODULE_YIELD) {
-		if (UNLANG_DETACHABLE) request_detach(child);
+		request_detach(child);
 		talloc_free(child);
 		*presult = rcode;
 		*priority = instruction->actions[*presult];
@@ -1114,7 +1114,8 @@ static rlm_rcode_t unlang_parallel_run(REQUEST *request, unlang_parallel_t *stat
 	rad_assert(done = CHILD_DONE);
 
 	/*
-	 *	Clean up all of the children as soon as possible.
+	 *	Clean up all of the child requests, because once we
+	 *	return, no one can access their data any more.
 	 */
 	for (i = 0; i < state->num_children; i++) {
 		if ((state->children[i].state == CHILD_YIELDED) ||