From: Martin Willi <martin@revosec.ch>
Date: Wed, 22 Oct 2014 09:24:51 +0000 (+0200)
Subject: threading: Support rwlock try_write_lock() on Windows
X-Git-Tag: 5.2.2dr1~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=61e29aca0dcc3e706a97d3b95d988b65723535a5;p=thirdparty%2Fstrongswan.git

threading: Support rwlock try_write_lock() on Windows

We explicitly avoided TryAcquireSRWLockExclusive() because of crashes. This
issue was caused by a MinGW-w64 bug (mingw-w64 fix 46f77afc). Using a newer
toolchain works fine.

While try_write_lock() obviously can fail, not supporting it is not really an
option, as some algorithms depend on occasionally successful calls. Certificate
caching in the certificate manager and the cred_set cache rely on successful
try_write_lock()ing.
---

diff --git a/src/libstrongswan/threading/windows/rwlock.c b/src/libstrongswan/threading/windows/rwlock.c
index 0de57f7135..fc0d6d8649 100644
--- a/src/libstrongswan/threading/windows/rwlock.c
+++ b/src/libstrongswan/threading/windows/rwlock.c
@@ -85,8 +85,6 @@ METHOD(rwlock_t, write_lock, void,
 METHOD(rwlock_t, try_write_lock, bool,
 	private_rwlock_t *this)
 {
-	/* TODO: causes random failures and segfaults. Bug? */
-	return FALSE;
 	return TryAcquireSRWLockExclusive(&this->srw);
 }