From: Fabiano Fidêncio <fidencio@redhat.com>
Date: Thu, 19 Dec 2019 09:17:11 +0000 (+0100)
Subject: storage: Don't check the output of virGetUserRuntimeDirectory()
X-Git-Tag: v6.0.0-rc1~155
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6207bee80be427f101b357b0d71adb629442a628;p=thirdparty%2Flibvirt.git

storage: Don't check the output of virGetUserRuntimeDirectory()

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 71078dfbd6..a33328db37 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -278,8 +278,6 @@ storageStateInitialize(bool privileged,
     } else {
         configdir = virGetUserConfigDirectory();
         rundir = virGetUserRuntimeDirectory();
-        if (!rundir)
-            goto error;
 
         driver->configDir = g_strdup_printf("%s/storage", configdir);
         driver->autostartDir = g_strdup_printf("%s/storage/autostart", configdir);