From: Bartosz Sławecki <bartosz@ilikepython.com>
Date: Sun, 11 Jan 2026 19:24:19 +0000 (+0100)
Subject: gh-127750: Fix annotations in singledispatchmethod signature tests (GH-143571)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=620a5b92693ac1b2cef1f90fd3c2dba1bb794552;p=thirdparty%2FPython%2Fcpython.git

gh-127750: Fix annotations in singledispatchmethod signature tests (GH-143571)

These tests relied on a bug -- gh-84644, which is that singledispatch
doesn't verify the annotation is on the "first" parameter.
---

diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py
index 459d56f82d68..94b469397139 100644
--- a/Lib/test/test_functools.py
+++ b/Lib/test/test_functools.py
@@ -3450,16 +3450,11 @@ class TestSingleDispatch(unittest.TestCase):
 
     def test_method_signatures(self):
         class A:
-            def m(self, item, arg: int) -> str:
-                return str(item)
-            @classmethod
-            def cm(cls, item, arg: int) -> str:
-                return str(item)
             @functools.singledispatchmethod
             def func(self, item, arg: int) -> str:
                 return str(item)
             @func.register
-            def _(self, item, arg: bytes) -> str:
+            def _(self, item: int, arg: bytes) -> str:
                 return str(item)
 
             @functools.singledispatchmethod
@@ -3468,7 +3463,7 @@ class TestSingleDispatch(unittest.TestCase):
                 return str(arg)
             @func.register
             @classmethod
-            def _(cls, item, arg: bytes) -> str:
+            def _(cls, item: int, arg: bytes) -> str:
                 return str(item)
 
             @functools.singledispatchmethod
@@ -3477,7 +3472,7 @@ class TestSingleDispatch(unittest.TestCase):
                 return str(arg)
             @func.register
             @staticmethod
-            def _(item, arg: bytes) -> str:
+            def _(item: int, arg: bytes) -> str:
                 return str(item)
 
         self.assertEqual(str(Signature.from_callable(A.func)),