From: Russell Bryant <russell@russellbryant.com>
Date: Mon, 2 Jul 2007 19:01:16 +0000 (+0000)
Subject: Add a note that the AGI commands array is not handled in a thread-safe way
X-Git-Tag: 1.6.0-beta1~3^2~2179
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=625dbb6f898d73ffb3fe53c356b8cc29f8a95c98;p=thirdparty%2Fasterisk.git

Add a note that the AGI commands array is not handled in a thread-safe way


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_agi.c b/res/res_agi.c
index 470d0599b3..cd7e0a928e 100644
--- a/res/res_agi.c
+++ b/res/res_agi.c
@@ -1603,6 +1603,13 @@ static char usage_noop[] =
 " Usage: NoOp\n"
 "	Does nothing.\n";
 
+/*!
+ * \brief AGI commands
+ *
+ * \todo XXX This array is not handled in a thread safe way.  There is no
+ * synchronization done at all between the agi register and unregister functions
+ * and the rest of this module which uses the entries here.
+ */
 static agi_command commands[MAX_COMMANDS] = {
 	{ { "answer", NULL }, handle_answer, "Answer channel", usage_answer },
 	{ { "channel", "status", NULL }, handle_channelstatus, "Returns status of the connected channel", usage_channelstatus },