From: Doug MacEachern <dougm@apache.org>
Date: Thu, 28 Feb 2002 03:21:51 +0000 (+0000)
Subject: contrary to what comments say, DH* returned from ssl_dh_GetTmpParam()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=62710ab8e91d347365d6ec2d93f86fcbe17b27f1;p=thirdparty%2Fapache%2Fhttpd.git

contrary to what comments say, DH* returned from ssl_dh_GetTmpParam()
is _not_ static and needs to be freed via DH_free().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@93624 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/ssl_engine_init.c b/ssl_engine_init.c
index 9a37e4cf286..8cea93d3ef0 100644
--- a/ssl_engine_init.c
+++ b/ssl_engine_init.c
@@ -318,7 +318,7 @@ void ssl_init_TmpKeysHandle(int action, server_rec *s, apr_pool_t *p)
         length = i2d_DHparams(dh, NULL);
         ucp = ssl_asn1_table_set(mc->tTmpKeys, "DH:512", length);
         (void)i2d_DHparams(dh, &ucp); /* 2nd arg increments */
-        /* no need to free dh, it's static */
+        DH_free(dh);
 
         /* import 1024 bit DH param */
         if ((dh = ssl_dh_GetTmpParam(1024)) == NULL) {
@@ -329,7 +329,7 @@ void ssl_init_TmpKeysHandle(int action, server_rec *s, apr_pool_t *p)
         length = i2d_DHparams(dh, NULL);
         ucp = ssl_asn1_table_set(mc->tTmpKeys, "DH:1024", length);
         (void)i2d_DHparams(dh, &ucp); /* 2nd arg increments */
-        /* no need to free dh, it's static */
+        DH_free(dh);
     }
 
     /* Allocate Keys and Params */