From: Volker Lendecke <vl@samba.org>
Date: Sat, 13 Dec 2008 09:31:11 +0000 (+0100)
Subject: Fix a valgrind error in get_relative_fid_filename
X-Git-Tag: samba-4.0.0alpha6~479^2~3^2~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=627c844a13caf869ae3c68ec780a8eded7cb181d;p=thirdparty%2Fsamba.git

Fix a valgrind error in get_relative_fid_filename

It doesn't really make sense to check the length of a not-yet-allocated string
:-)

Volker
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 1e988f65ec6..d22eda2bb54 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3067,7 +3067,7 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
 	files_struct *dir_fsp;
 	char *parent_fname = NULL;
 
-	if (root_dir_fid == 0 || !fname || !new_fname || !*new_fname) {
+	if (root_dir_fid == 0 || !fname || !new_fname) {
 		return NT_STATUS_INTERNAL_ERROR;
 	}