From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 3 Oct 2025 01:27:18 +0000 (+1300)
Subject: s4:cracknames: initialise a string variable
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=628d62e6f4789e298068e1ce18de700929d5b481;p=thirdparty%2Fsamba.git

s4:cracknames: initialise a string variable

because later we go

	ret = krb5_unparse_name_flags([...],
				      &unparsed_name_short);
	if (ret) {
		free(unparsed_name_short);
		return WERR_NOT_ENOUGH_MEMORY;
	}

which is bad if a krb5_unparse_name_flags() errors without setting
unparsed_name_short -- not that I see that happening in MIT or Heimdal.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c
index c04d4aed572..c1066e269a1 100644
--- a/source4/dsdb/samdb/cracknames.c
+++ b/source4/dsdb/samdb/cracknames.c
@@ -286,7 +286,7 @@ static WERROR DsCrackNameUPN(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
 	krb5_principal principal;
 	char *realm;
 	char *realm_encoded = NULL;
-	char *unparsed_name_short;
+	char *unparsed_name_short = NULL;
 	const char *unparsed_name_short_encoded = NULL;
 	const char *domain_attrs[] = { NULL };
 	struct ldb_result *domain_res = NULL;