From: Marcin Siodelski Date: Wed, 30 Oct 2019 09:05:14 +0000 (+0100) Subject: [#964,!577] Two trivial fixes as a result of second review. X-Git-Tag: Kea-1.7.2~79 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=628d764179824329a5c654d69a9934f174d23e4a;p=thirdparty%2Fkea.git [#964,!577] Two trivial fixes as a result of second review. - Addeed asterisk in the changelog to mark it incompatible change. - Fixed comma character in the new line. --- diff --git a/ChangeLog b/ChangeLog index 8c8025e431..9a7056eb99 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +1682. [bug]* tmark + Added logic to core code and HA hook lib to allow HA peers + to detect and handle out of bandwidth socket events. This + corrects a defect introduced in Kea 1.6.0 that can cause + an HA server to become unresponsive when an HA socket has + been closed by a peer. Note that there is a change to the + signature of the external socket callback handler invoked + by IfaceMgr. Custome hook libraries happen register external + sockets with IfaceMgr will require modification and + recompilation. + (Gitlab #964) + Kea 1.7.1 released on Oct 30, 2019 1681. [func] fdupont diff --git a/src/hooks/dhcp/high_availability/ha_service.h b/src/hooks/dhcp/high_availability/ha_service.h index 68129f5744..14486e1a80 100644 --- a/src/hooks/dhcp/high_availability/ha_service.h +++ b/src/hooks/dhcp/high_availability/ha_service.h @@ -747,9 +747,9 @@ protected: /// The handler calls @ref HttpClient::closeIfOutOfBandwidth() to catch /// and close any sockets that have gone ready outside of transactions. /// - /// We do this in case the other peer closed the socket (e.g. idle timeout - /// for example), as this will cause the socket /appear ready to read to - /// the IfaceMgr::select(). If this happens while no transcations are + /// We do this in case the other peer closed the socket (e.g. idle timeout), + /// as this will cause the socket to appear ready to read to the + /// IfaceMgr::select(). If this happens while no transcations are /// in progess, we won't have anything to deal with the socket event. /// This causes IfaceMgr::select() to endlessly interrupt on the socket. ///