From: Jason Ish <jason.ish@oisf.net>
Date: Mon, 4 Jan 2021 16:48:20 +0000 (-0600)
Subject: email/eve: use Rust function to hash buffer to hex
X-Git-Tag: suricata-7.0.0-beta1~1877
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6299222c4ef8b7c2dcb81b2ce0866f7af858663f;p=thirdparty%2Fsuricata.git

email/eve: use Rust function to hash buffer to hex

Use SCMd5HashBufferToHex to hash the subject to a hex string.
Removes snprintf loop.
---

diff --git a/src/output-json-email-common.c b/src/output-json-email-common.c
index 4fd79859d4..93e54119fa 100644
--- a/src/output-json-email-common.c
+++ b/src/output-json-email-common.c
@@ -131,15 +131,10 @@ static void EveEmailLogJSONMd5(OutputJsonEmailCtx *email_ctx, JsonBuilder *js, S
         }
         field = MimeDecFindField(entity, "subject");
         if (field != NULL) {
-            unsigned char md5[SC_MD5_LEN];
-            char smd5[256];
+            char smd5[SC_MD5_HEX_LEN + 1];
             char *value = BytesToString((uint8_t *)field->value , field->value_len);
             if (value) {
-                size_t i,x;
-                SCMd5HashBuffer((uint8_t *)value, strlen(value), md5, sizeof(md5));
-                for (i = 0, x = 0; x < sizeof(md5); x++) {
-                    i += snprintf(smd5 + i, 255 - i, "%02x", md5[x]);
-                }
+                SCMd5HashBufferToHex((uint8_t *)value, strlen(value), smd5, sizeof(smd5));
                 jb_set_string(js, "subject_md5", smd5);
                 SCFree(value);
             }