From: Michal Privoznik Date: Thu, 14 May 2020 09:26:22 +0000 (+0200) Subject: qemuBlockJobDataDisposeJobdata: Free data.commit.disabledBitmapsBase X-Git-Tag: v6.4.0-rc1~89 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=62c27cfc4f693e7ffd1e8f31942bc9c51dfaf815;p=thirdparty%2Flibvirt.git qemuBlockJobDataDisposeJobdata: Free data.commit.disabledBitmapsBase ==179663== 35 (24 direct, 11 indirect) bytes in 1 blocks are definitely lost in loss record 205 of 461 ==179663== at 0x4839EC6: calloc (vg_replace_malloc.c:762) ==179663== by 0x5791AC0: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.6400.1) ==179663== by 0x190C79: qemuDomainObjPrivateXMLParseBlockjobDataCommit (qemu_domain.c:3295) ==179663== by 0x190DF7: qemuDomainObjPrivateXMLParseBlockjobDataSpecific (qemu_domain.c:3331) ==179663== by 0x19157D: qemuDomainObjPrivateXMLParseBlockjobData (qemu_domain.c:3469) ==179663== by 0x1918E8: qemuDomainObjPrivateXMLParseBlockjobs (qemu_domain.c:3498) ==179663== by 0x193841: qemuDomainObjPrivateXMLParse (qemu_domain.c:3944) ==179663== by 0x4A1BA9D: virDomainObjParseXML (domain_conf.c:22306) ==179663== by 0x4A1BFE9: virDomainObjParseNode (domain_conf.c:22429) ==179663== by 0x4A1C0B4: virDomainObjParseFile (domain_conf.c:22443) ==179663== by 0x1431E1: testCompareStatusXMLToXMLFiles (qemuxml2xmltest.c:61) ==179663== by 0x177722: virTestRun (testutils.c:142) Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index e51499532f..17dc08476b 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -84,6 +84,11 @@ qemuBlockJobDataDisposeJobdata(qemuBlockJobDataPtr job) virObjectUnref(job->data.backup.store); g_free(job->data.backup.bitmap); } + + if (job->type == QEMU_BLOCKJOB_TYPE_COMMIT || + job->type == QEMU_BLOCKJOB_TYPE_ACTIVE_COMMIT) { + virStringListFree(job->data.commit.disabledBitmapsBase); + } }